Comments (3)
I can work on this issue. @driesvints
Context
What is causing this issue is the class "container" on the transition from xl to lg.
- Max width of
XL
is 1280px. - Max width of
LG
is 1024px.
and as the layout use "container and mx-auto" we lose some space on lg screens.
Solution
One of the solutions that I was thinking of it would be hide the avatar from medium to large screens.
Improvements
apart of that I can noticed some more minor ui things on transitions from xl to smaller screens:
- Navigation, icons & auth buttons looks like compressed on medium screens, Login button doesn't have space to follow the container size.
![](https://private-user-images.githubusercontent.com/74480106/311696646-c1d56954-70e7-4f2c-bc47-6da99f9cbd77.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTY0OTI0MDEsIm5iZiI6MTcxNjQ5MjEwMSwicGF0aCI6Ii83NDQ4MDEwNi8zMTE2OTY2NDYtYzFkNTY5NTQtNzBlNy00ZjJjLWJjNDctNmRhOTlmOWNiZDc3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTIzVDE5MjE0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRmMmZmMmU1NDQzZTBjZTc4MWE0NmUxZTQ1MjhjYjk3YmEyNDExYmExZjZkOTA0MWI2NjhlMTdhNTIzYThkMWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.YaVmikRVMLMSlrVwntbY6OUSIOwyclUAGqYT71dS3-E)
- Navigation has some weird x-padding and is not be aligned with the container.
![](https://private-user-images.githubusercontent.com/74480106/311698038-8fa73fdc-817c-4757-8a79-4ae288391120.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTY0OTI0MDEsIm5iZiI6MTcxNjQ5MjEwMSwicGF0aCI6Ii83NDQ4MDEwNi8zMTE2OTgwMzgtOGZhNzNmZGMtODE3Yy00NzU3LThhNzktNGFlMjg4MzkxMTIwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTIzVDE5MjE0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM2Y2UyNmRlNzI1NDY0YzE3NWEzNTcxNTdiYjIwNjJiZjc0MDRmM2JlODZmY2FlN2Q3MTdjNWI4ZDM3ZDJmOWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.UPhowfhbEz7Nh09akkeN9LYG2WKaHryBOeGX35XKZ-0)
Please let me know if hide the avatar could be the solution to this issue, and if I should open an issue & pr to fix this two minor things.
from laravel.io.
Hmm I think we'd still want to show the avatar. Maybe we can work with a truncate on the username and also make the font smaller on that breakpoint?
from laravel.io.
https://tailwindcss.com/docs/text-overflow#truncate
from laravel.io.
Related Issues (20)
- Setup Pulse
- Dark mode shouldn't be applied for pagination HOT 3
- Better empty state page for notifications
- Move language strings from lang dir to inline usage
- API token created but the token is not showing
- Move social icons HOT 2
- Add hotkey for search HOT 2
- Move GenerateSocialShareImage to a sync job
- Add repositories check to new users to battle spam
- Do not count banned users on homepage
- Use proper GitHub wording
- Upgrade Pest from v1 to v2
- Migrate BrowserKit tests to HTTP tests HOT 3
- Migrate admin parts to Filament HOT 1
- Tests fail locally
- Improve testing speed
- Upgrade to PHP 8.3
- Upgrade to Vite v5 and Laravel vite-plugin v1
- Show usernames when hovering over like icon
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laravel.io.