Having Horizon installed is breaking some tests about horizon HOT 8 CLOSED

@driesvints noted, thanks for the info. I'll settle for just mocking the call to driver() that Horizon ends up calling, as so far that doesn't seem to have any negative repercussions.

from horizon.

You're doing cache faking here: https://github.com/rpungello/laravel-test/blob/master/tests/Feature/ExampleTest.php#L16-L19

This doesn't work when installing Horizon because it needs to resolve the cache driver upon initialisation through its service provider. Since you only added one expectation to the cache faking, this fails.

from horizon.

@driesvints is this documented somewhere? I followed the official Laravel docs for mocking facades, which explicitly show the method for mocking the Cache facade I used: https://laravel.com/docs/11.x/mocking#mocking-facades

from horizon.

@rpungello I want to check something real quickly with you. Does it work if you replace:

            $this->app->bind(Console\WorkCommand::class, function ($app) {
                return new Console\WorkCommand($app['queue.worker'], $app['cache.store']);
            });

With

        if ($this->app->runningInConsole()) {
            $this->app->bind(Console\WorkCommand::class, function ($app) {
                return new Console\WorkCommand($app['queue.worker'], $app['cache.store']);
            });
        }

In the HorizonServiceProvider?

from horizon.

@driesvints it doesn't, though that at least gives me some info on where to look. Commenting out that section and preventing registerCommands() from running during boot() does solve the issue, but obviously that can't be done unilaterally without breaking Horizon.

Your suggestion of using runningInConsole() lead me to the runningUnitTests() function of $this->app, but regrettably that returns false during the initialization of Horizon (despite returning true while actually running the example test).

It does seem possible to work around the issue by adding an expectation that driver() be called on the cache facade, but it's unclear if that could result in other issues if there's a scenario where Horizon doesn't end up calling that function.

from horizon.

Looking at this a little closer, within HorizonServiceProvider::registerCommands(), changing
if ($this->app->runningInConsole()) {
to
if ($this->app->runningInConsole() && !$this->app->runningUnitTests()) {
Does resolve the issue. I was mistaken previously that runningUnitTests() returned false, that was for the standard ExampleTest Laravel ships with, but for my test feature test it does return true.

What I don't know is whether this could realistically be modified without breaking something else.

from horizon.

@rpungello let's try it: #1410

from horizon.

Unfortunately it doesn't seems possible since we need some of these commands themselves in our own test suite. I'm sorry @rpungello but it seems these two just aren't compatible right now.

from horizon.