Giter Club home page Giter Club logo

Comments (4)

Naoray avatar Naoray commented on June 10, 2024

Why don't we add a setting is set to allow nullables by default to prevent a breaking change?

'factory_fill_nullable' => true,

Then we just need to check if the setting is set to false and if so filter the $models->columns() based on the nullable modifier.

from blueprint.

jasonmccreary avatar jasonmccreary commented on June 10, 2024

Yeah. That's fair. Maybe in 2.0, I'll change this to false.

The more I test, the more I don't like the nullable columns to be filled as it forces me to explicit set these in my test case or, better yet, add a factory state.

Let's move forward with the config setting approach with an option of fake_nullables. Don't worry about the heading doc, I'll write something up and amend the PR.

from blueprint.

Naoray avatar Naoray commented on June 10, 2024

👍 will give it a try tomorrow morning

from blueprint.

Naoray avatar Naoray commented on June 10, 2024

was easier than expected 😄

from blueprint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.