Support views with single child dynamically updating about floem HOT 14 CLOSED

It's probably like this

pub fn container_box(child: impl Fn() -> Box<dyn View> + 'static) -> ContainerBox {
    let cx = ViewContext::get_current();
    let id = cx.new_id();
    let mut curr_cx = cx;
    curr_cx.id = id;
    ViewContext::save();
    ViewContext::set_current(curr_cx);
    let temp_child = crate::views::empty();
    ViewContext::restore();
    
     create_effect(cx.scope, move |_| {
        ViewContext::save();
        ViewContext::set_current(curr_cx);
        let new_child = child();
        id.update_state(new_child, false);
        ViewContext::restore();
    });

    ContainerBox {
        id,
        child: Box::new(temp_child),
    }
}

from floem.

It would probably also be good to consider how animation could be built into this.

As this is probably one of the most natural ways to change between views it would also make sense to be able to apply animations on the change.

This would work well SVGs that dynamically change

from floem.

It's probably like this

For me this still panics in the same place with a borrow_mut error

from floem.

It doesn't for me. Maybe paste the full trace?

from floem.

thread 'main' panicked at 'already borrowed: BorrowMutError', /Users/jaredmoulton/Developer/floem/absolute-position/src/id.rs:68:22
stack backtrace:
0: rust_begin_unwind
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:578:5
1: core::panicking::panic_fmt
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:67:14
2: core::result::unwrap_failed
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/result.rs:1687:5
3: core::result::Result<T,E>::expect
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/result.rs:1046:23
4: core::cell::RefCell::borrow_mut
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/cell.rs:1018:9
5: floem::id::Id::new::{{closure}}
at /Users/jaredmoulton/Developer/floem/absolute-position/src/id.rs:68:13
6: std::thread::local::LocalKey::try_with
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/thread/local.rs:252:16
7: std::thread::local::LocalKey::with
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/thread/local.rs:228:9
8: floem::id::Id::new
at /Users/jaredmoulton/Developer/floem/absolute-position/src/id.rs:67:9
9: floem::app_handle::ViewContext::new_id
at /Users/jaredmoulton/Developer/floem/absolute-position/src/app_handle.rs:111:9
10: floem::app_handle::ViewContext::new_id_with_child
at /Users/jaredmoulton/Developer/floem/absolute-position/src/app_handle.rs:95:18
11: floem::views::stack::stack
at /Users/jaredmoulton/Developer/floem/absolute-position/src/views/stack.rs:17:26
12: leviathan_gui::default_wave_options
at ./src/main.rs:656:5
13: leviathan_gui::wave_options::{{closure}}
at ./src/main.rs:632:42
14: floem::views::container_box::container_box::{{closure}}
at /Users/jaredmoulton/Developer/floem/absolute-position/src/views/container_box.rs:28:25
15: <leptos_reactive::effect::Effect<T,F> as leptos_reactive::effect::AnyComputation>::run
at /Users/jaredmoulton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/leptos_reactive-0.3.0/src/effect.rs:195:25
16: leptos_reactive::runtime::Runtime::update::{{closure}}
at /Users/jaredmoulton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/leptos_reactive-0.3.0/src/runtime.rs:129:25
17: leptos_reactive::runtime::Runtime::with_observer
at /Users/jaredmoulton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/leptos_reactive-0.3.0/src/runtime.rs:178:17
18: leptos_reactive::runtime::Runtime::update
at /Users/jaredmoulton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/leptos_reactive-0.3.0/src/runtime.rs:125:21
19: leptos_reactive::runtime::Runtime::update_if_necessary
at /Users/jaredmoulton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/leptos_reactive-0.3.0/src/runtime.rs:102:13
20: leptos_reactive::runtime::Runtime::run_effects
at /Users/jaredmoulton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/leptos_reactive-0.3.0/src/runtime.rs:338:17
21: leptos_reactive::signal::::update::{{closure}}
at /Users/jaredmoulton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/leptos_reactive-0.3.0/src/signal.rs:1937:17
22: leptos_reactive::runtime::with_runtime::{{closure}}
at /Users/jaredmoulton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/leptos_reactive-0.3.0/src/runtime.rs:382:41
23: std::thread::local::LocalKey::try_with
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/thread/local.rs:252:16
24: std::thread::local::LocalKey::with
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/thread/local.rs:228:9
25: leptos_reactive::runtime::with_runtime
at /Users/jaredmoulton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/leptos_reactive-0.3.0/src/runtime.rs:378:13
26: leptos_reactive::signal::::update
at /Users/jaredmoulton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/leptos_reactive-0.3.0/src/signal.rs:1907:9
27: <leptos_reactive::signal::RwSignal as leptos_reactive::signal::SignalUpdate>::update
at /Users/jaredmoulton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/leptos_reactive-0.3.0/src/signal.rs:1511:12
28: leviathan_gui::channel::{{closure}}::{{closure}}::{{closure}}
at ./src/main.rs:612:35
29: leviathan_gui::components::scrollable_dropdown::{{closure}}::{{closure}}::{{closure}}::{{closure}}
at ./src/components.rs:80:33
30: <alloc::boxed::Box<F,A> as core::ops::function::Fn>::call
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/alloc/src/boxed.rs:1987:9
31: floem::view::View::event_main
at /Users/jaredmoulton/Developer/floem/absolute-position/src/view.rs:496:74
32: floem::view::View::event_main
at /Users/jaredmoulton/Developer/floem/absolute-position/src/view.rs:336:24
33: floem::view::View::event_main
at /Users/jaredmoulton/Developer/floem/absolute-position/src/view.rs:336:24
34: floem::view::View::event_main
at /Users/jaredmoulton/Developer/floem/absolute-position/src/view.rs:336:24
35: floem::view::View::event_main
at /Users/jaredmoulton/Developer/floem/absolute-position/src/view.rs:336:24
36: floem::view::View::event_main
at /Users/jaredmoulton/Developer/floem/absolute-position/src/view.rs:336:24
37: floem::view::View::event_main
at /Users/jaredmoulton/Developer/floem/absolute-position/src/view.rs:336:24
38: floem::view::View::event_main
at /Users/jaredmoulton/Developer/floem/absolute-position/src/view.rs:336:24
39: floem::view::View::event_main
at /Users/jaredmoulton/Developer/floem/absolute-position/src/view.rs:336:24
40: floem::view::View::event_main
at /Users/jaredmoulton/Developer/floem/absolute-position/src/view.rs:336:24
41: floem::view::View::event_main
at /Users/jaredmoulton/Developer/floem/absolute-position/src/view.rs:336:24
42: floem::view::View::event_main
at /Users/jaredmoulton/Developer/floem/absolute-position/src/view.rs:336:24
43: floem::view::View::event_main
at /Users/jaredmoulton/Developer/floem/absolute-position/src/view.rs:336:24
44: floem::app_handle::AppHandle::event::{{closure}}
at /Users/jaredmoulton/Developer/floem/absolute-position/src/app_handle.rs:703:21
45: std::thread::local::LocalKey::try_with
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/thread/local.rs:252:16
46: std::thread::local::LocalKey::with
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/thread/local.rs:228:9
47: floem::app_handle::AppHandle::event
at /Users/jaredmoulton/Developer/floem/absolute-position/src/app_handle.rs:701:13
48: <floem::app_handle::AppHandle as glazier::window::WinHandler>::pointer_up
at /Users/jaredmoulton/Developer/floem/absolute-position/src/app_handle.rs:860:9
49: glazier::window::WinHandler::mouse_up
at /Users/jaredmoulton/.cargo/git/checkouts/glazier-b8f821eee8f52b00/ab692f5/src/window.rs:702:9
50: glazier::backend::mac::window::mouse_up
at /Users/jaredmoulton/.cargo/git/checkouts/glazier-b8f821eee8f52b00/ab692f5/src/backend/mac/window.rs:835:9
51: glazier::backend::mac::window::mouse_up_left
at /Users/jaredmoulton/.cargo/git/checkouts/glazier-b8f821eee8f52b00/ab692f5/src/backend/mac/window.rs:809:5
52:
53:
54:
55:
56:
57:
58: <() as objc::message::MessageArguments>::invoke
at /Users/jaredmoulton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/objc-0.2.7/src/message/mod.rs:128:17
59: objc::message::platform::send_unverified
at /Users/jaredmoulton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/objc-0.2.7/src/message/apple/mod.rs:27:9
60: objc::message::send_message
at /Users/jaredmoulton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/objc-0.2.7/src/message/mod.rs:178:5
61: <*mut objc::runtime::Object as cocoa::appkit::NSApplication>::run
at /Users/jaredmoulton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cocoa-0.24.1/src/appkit.rs:464:9
62: glazier::backend::mac::application::Application::run
at /Users/jaredmoulton/.cargo/git/checkouts/glazier-b8f821eee8f52b00/ab692f5/src/backend/mac/application.rs:74:13
63: glazier::application::Application::run
at /Users/jaredmoulton/.cargo/git/checkouts/glazier-b8f821eee8f52b00/ab692f5/src/application.rs:153:9
64: floem::app::Application::run
at /Users/jaredmoulton/Developer/floem/absolute-position/src/app.rs:92:9
65: leviathan_gui::main
at ./src/main.rs:62:5
66: core::ops::function::FnOnce::call_once
at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with RUST_BACKTRACE=full for a verbose backtrace.

from floem.

It's because these two has already borrowed it.

https://github.com/lapce/floem/blob/main/src/app_handle.rs#L654
https://github.com/lapce/floem/blob/main/src/app_handle.rs#L701

You'll need to get the id_path out like here https://github.com/lapce/floem/blob/main/src/app_handle.rs#L472

from floem.

Sweet! No longer panicking. But things are still showing up empty so I'm guessing that the child isn't getting the correct context. I'm not sure if that is a problem with my testing code or in container_box. In your test are you seeing elements populate correctly?

from floem.

Is the new View appear in the update?

from floem.

fn update(
    &mut self,
    cx: &mut crate::context::UpdateCx,
    state: Box<dyn std::any::Any>,
) -> crate::view::ChangeFlags {
    if let Ok(child) = state.downcast() {
        self.child = *child;
        cx.request_layout(self.id());
        ChangeFlags::LAYOUT
    } else {
        ChangeFlags::empty()
    }
}

from floem.

I mean you'll need to debug if the new child is actually sent to the update, or was it error in downcast.

from floem.

I do get changes but not everything. It seems like it doesn't update the child views all the way down.

from floem.

I mean you'll need to debug if the new child is actually sent to the update, or was it error in downcast.

Definitely getting the child in the update and no errors in downcast

from floem.

Send a PR in. Maybe that would be easier.

from floem.

Added in #67

from floem.