babel / es5 compatability about lance HOT 6 CLOSED

Hi Alan, thanks for the issue, I'm a big fan of your work. :)

Incheon is not meant to be packaged independently. It is a library which ultimately gets packaged into
a host game project. There are examples for both browserify and webpack packaging.
Take a look at the boilerplate game repository: https://github.com/namel/incheongame
Or better yet, you're invited to walk through one of the tutorials in the documentation:
http://docs.incheon.gg/develop/index.html

from lance.

@namel ;)

I am not so much talking about packaging as transpiling.

The problem is that using babel, it expects code to be either es5 compatable, or transpiled (which is basically the same thing). Since incheon exports es6 code (class), and is not transpiled by default when the user requires it (babel ignores node_modules) babel cannot handle when you do something like:

const GameEngine = require('incheon').GameEngine
class MyGameEngine extends GameEngine { }

This won't compile in a standard babel/webpack setup. It is possible to have babel transpile this package by ignoring it, but this ultimatley puts the burden on the user, which IMO is less than ideal. I would rather have you state that you do not support es5 if that is the case.

I've put together a reproduction repo to better illustrate the problem: https://github.com/GGAlanSmithee/incheon-babel-test

from lance.

What about the option of configuring webpack with babel-loader? We used this to
get babel/webpack to work together, and extended the GameEngine class as you described above.

@OpherV got this to work by specifying the webpack babel-loader in webpack.config.js

Take a look at our spaaace demo repository, and specifically at the webpack.config.js file:

https://github.com/OpherV/spaaace

from lance.

@namel yeah, looks like you are manually including incheon for transpilation in that project https://github.com/OpherV/spaaace/blob/master/webpack.config.js#L25

This is a real option, and sooner or later I guess we need to move toward es6, but I think you should make this clear in the documentation, want a PR for the docs?

from lance.

would be great

from lance.

@namel #42 (what a magic number) let me know if want anything to be changed.

from lance.