v3 proposal about laminas-validator HOT 5 CLOSED

@snapshotpl
I see some problems, because you've mixed different problems in one commit:

• this breaks the version control system
• no way for a cherry-pick
• reading the commit history is a mess
• a review is very difficult

Each individual change should be one commit. Please create separate commits for each problem. Thank you in advance!

Originally posted by @froschdesign at zendframework/zend-validator#177 (comment)

from laminas-validator.

@snapshotpl Totally missed this when I submitted #181 earlier.

@froschdesign For large refactors, we simply cannot do one change at a time. In such cases, I would recommend posting a WIP with some of the ideas codified, and then creating an RFC in the contributors section of the forums. I'll be posting one related to #181 tomorrow, as I've done some significant work trying to address forwards and backwards compatibility at this point.

Originally posted by @weierophinney at zendframework/zend-validator#177 (comment)

from laminas-validator.

@weierophinney

For large refactors, we simply cannot do one change at a time.

You can, because a problem can change more than one line or one file!

Originally posted by @froschdesign at zendframework/zend-validator#177 (comment)

from laminas-validator.

I suppose it all depends on what a "change" is.

In this PR, there's a single commit that does two different things:

• Updates travis.yml and composer.json to PHP 7.1
• Adds Result.php, Message.php and the changes ValidatorInterface.php.

It seems to me that these should be two separate PRs. I agree with Matthew that more explanation on the reasons behind a significant change would be useful.

Originally posted by @akrabat at zendframework/zend-validator#177 (comment)

from laminas-validator.

@akrabat

I suppose it all depends on what a "change" is.

Replace the word "change" with "problem".

In this PR, there's a single commit that does two different things

Right!

I agree with Matthew that more explanation on the reasons behind a significant change would be useful.

I agree also.

I wanted to point out the problem with the "all-in-one-commits". No more.
We should add a new paragraph to the contributors guide to respect the principles of a version control system.

Originally posted by @froschdesign at zendframework/zend-validator#177 (comment)

from laminas-validator.