I believe this validator should either be rewritten or removed entirely a

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

GpsPoint validator needs a rewrite because it returns true for the input "foo, bar" about laminas-validator HOT 5 CLOSED

froschdesign commented on July 1, 2024

GpsPoint validator needs a rewrite because it returns true for the input "foo, bar"

from laminas-validator.

Comments (5)

froschdesign commented on July 1, 2024 2

@boesing

Yah, using is_numeric should be suitable here

This will fail with the current test cases because coordinates like 63 47 24.691 N are converted to 634724.691N. The error for "out of bounds" is not set.

laminas-validator/test/GPSPointTest.php

Lines 79 to 86 in ba665f5

 public function errorMessageTestValues(): array 

 { 

 return [ 

 ['63 47 24.691 N, 18 2 54.363 W', GpsPoint::OUT_OF_BOUNDS, '63 47 24.691 N'], 

 ['° \' " N,° \' " E', GpsPoint::CONVERT_ERROR, '° \' " N'], 

 ['° \' " N', GpsPoint::INCOMPLETE_COORDINATE, '° \' " N'], 

 ]; 

 }

from laminas-validator.

Ocramius commented on July 1, 2024 1

Deprecation would be best then.

from laminas-validator.

froschdesign commented on July 1, 2024

I have checked it in the unit tests and confirm the problem.

from laminas-validator.

froschdesign commented on July 1, 2024

Another option would be to check if a number is included before conversion to double is done:

laminas-validator/src/GpsPoint.php

Lines 71 to 78 in ba665f5

 $doubleLatitude = (double) $value; 

 if ($doubleLatitude <= $maxBoundary && $doubleLatitude >= $maxBoundary * -1) { 

 return true; 

 } 

 $this->error(self::OUT_OF_BOUNDS); 

 return false;

from laminas-validator.

boesing commented on July 1, 2024

Yah, using is_numeric should be suitable here

from laminas-validator.

GpsPoint validator needs a rewrite because it returns true for the input "foo, bar" about laminas-validator HOT 5 CLOSED

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	public function errorMessageTestValues(): array
	{
	return [
	['63 47 24.691 N, 18 2 54.363 W', GpsPoint::OUT_OF_BOUNDS, '63 47 24.691 N'],
	['° \' " N,° \' " E', GpsPoint::CONVERT_ERROR, '° \' " N'],
	['° \' " N', GpsPoint::INCOMPLETE_COORDINATE, '° \' " N'],
	];
	}

	$doubleLatitude = (double) $value;

	if ($doubleLatitude <= $maxBoundary && $doubleLatitude >= $maxBoundary * -1) {
	return true;
	}

	$this->error(self::OUT_OF_BOUNDS);
	return false;