Comments (3)
First, for anyone reading this, you need to apply PR #233 before running this code.
@sasezaki your suggestion will not work. However, may be interesting to add an "ob_end_flush" at the end of "listen" method (not ob_end_clean).
In order to reduce memory usage is necessary a call to "ob_flush" after each "read" call in SapiStreamEmitter.php.
However I believe this may cause performance issues in most production environments.
The flush calls has a very high performance cost.
And besides this, the PHP engine already regularly flushes output buffer, following "output_buffering" configuration directive.
Which I believe is more appropriate because it allows the application admin to choose the best balance between resource consumption and performance.
And depending of layers beyond PHP engine, the "ob_flush" may be pointless (e.g. Apache buffering when using gzip).
Originally posted by @fcabralpacheco at zendframework/zend-diactoros#232 (comment)
from laminas-diactoros.
It has been months (literally) since I started looking for a solution.
In my case, here is what did the trick - Note that I'm only using the SapiStreamEmitter:
ob_end_flush();
ob_implicit_flush();
$emitter->emit($response);
I'm not sure if this is really efficient, but at least it works (with large files ofc). I still need to try it in prod though..
Not taking any credit here. In fact, this is from an answer (that have some up votes) on ob_implicit_flush()
function at php.net: https://secure.php.net/manual/fr/function.ob-implicit-flush.php#116748
EDIT - After some more investigation.. We can simply do this. Way more cleaner.
ob_implicit_flush();
$maxBufferLevel = 0; // Stands for the maximum (and last) output buffering level to unwrap
$emitter->emit($response, $maxBufferLevel);
Originally posted by @cocochepeau at zendframework/zend-diactoros#232 (comment)
from laminas-diactoros.
SapiEmitter no longer part of laminas-diactoros
from laminas-diactoros.
Related Issues (20)
- Multiple use of the UploadedFile object in PHPUnit test cases with the same file results in errors - File is consumed HOT 2
- `UploadedFile::moveTo()` doesn't remove the original file when used in CLI context and keep grab the handle. HOT 1
- `FilterUsingXForwardedHeaders` should correctly deal with `<host>:<port>` pair in `X-FORWARDED-HOST` header HOT 9
- [RFC]: Allow better constraint handling for PHP HOT 2
- Could ServerRequestFactory::marshallUriFromSapi() be made public? HOT 4
- Update to PSR-7 1.1/2.0 HOT 2
- Remove image stream compatibility from `Stream`
- CVE-2023-29530: Fix For PHP 7.4 HOT 16
- CLI command to register diactoros as pinned for `php-http/discovery`
- Drop deprecated function marshalUriFromSapi
- PhpInputStream::getContent() inconsistency HOT 9
- RFC: Read php input stream content into php temp stream to allow all stream features in PhpInputStream HOT 1
- Numeric header names handling in PSR-7 message objects
- V3 getBody()->getContents() no longer returns full stream on second call HOT 3
- `composer.json` provides non-existing versions of `psr/http-factory`
- security vonerability HOT 1
- Plus signs in cookie data get converted to space.
- marshal_headers_from_sapi.php line 29 HOT 2
- `Uri::__toString()` can yield malformed URIs HOT 2
- 2.x series does not support PHP 8.3 HOT 20
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laminas-diactoros.