Comments (5)
Can you assign it to me @juanbono? :)
I should only rename it in the src/transaction
folder, right?
from starknet_in_rust.
@juanbono please i will like to work on this issue
from starknet_in_rust.
Can I work on this please?
from starknet_in_rust.
@juanbono still waiting to be assigned by you?
from starknet_in_rust.
I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
My recent focus in Ethereum-Solidity and Starknet-Cairo has significantly deepened my understanding of web3 technologies, positioning me well to contribute to innovative projects in the blockchain space. As an alumnus of Web3Bridge, where I received training in Solidity and Cairo, I have developed a solid foundation in these technologies. I am eager to contribute to open-source projects within the Starknet ecosystem, and I am particularly excited about the opportunity to make meaningful contributions to this project. Given the chance, I am committed to delivering my best work and leveraging my skills to drive success.
How I plan on tackling this issue
To approach the task of renaming the hash_value field to transaction_hash in the Starknet Rust project, start by understanding the codebase. Familiarize yourself with the project structure to identify where the hash_value field is defined and used. Create a map of dependencies and modules that interact with the hash_value field to understand its impact.
Next, locate the field definition. Search for the hash_value field definition in the codebase, which is likely found in a struct definition within a transactions module or similar context. Once located, rename the field from hash_value to transaction_hash.
Update all references to the field throughout the codebase. Use an IDE or text editor to search for all instances of hash_value and replace them with transaction_hash. This includes method calls, field accesses, and any relevant documentation or comments. Be cautious with partial matches to avoid unintended replacements.
Modify the test cases to use the new field name. This ensures that all test scenarios remain valid and continue to function correctly. Additionally, update any functions or methods that take hash_value as a parameter or return it, ensuring they use transaction_hash instead.
If backward compatibility is necessary, create aliases or compatibility layers to maintain the old field name while transitioning to the new one. This helps in gradually updating the codebase without breaking existing functionality.
Ensure all documentation reflects the change from hash_value to transaction_hash. Update inline documentation, README files, and any external documentation to maintain consistency and clarity.
Conduct a thorough code review with team members to catch any missed references or potential issues. Run the full test suite to ensure no existing functionality is broken. If possible, perform integration testing to verify the changes in a more realistic environment.
Finally, commit the changes with a descriptive message and follow the project’s deployment process to release the updates. This ensures that the changes are properly version-controlled and deployed without disrupting the project's workflow.
from starknet_in_rust.
Related Issues (20)
- Move Address from the utils module to the Transaction module
- Investigate failing txs when replaying txs with cairo native
- Run native - vm benchmarks on CI and report results on PRs
- Move ClassHash type to transaction module
- Remove #[allow(clippy::format_collect)] in fn serialize_memory HOT 1
- Update README to indicate Rust implementation in production"
- Unify tests into a single test binary to reduce output size, avoiding CI errors
- Remove declare_v2 module
- Bump `starknet-types-core` version to 0.0.9 HOT 1
- Investigate gas mismatch on new transactions HOT 1
- bug: secp256 syscalls missing
- Compiled class hash not found in `CachedState` after executing `Declare` tx HOT 2
- L2 to L1 message `from_address` HOT 3
- No Errors on Invalid Events HOT 2
- Update starknet-api version HOT 1
- Redundant gas fee in block context HOT 1
- 0.13.1.1 changes HOT 2
- Remove Cairo version 1 tests (keep only Cairo version 2 and Cairo zero)
- Kakarot test fails - status
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from starknet_in_rust.