Comments (13)
Weird, it seems that the error is coming from navigator.geolocation.getCurrentPosition
.
I will add some traces and catch to be sure this week-end.
from new-tab-moment.
Thanks for the issue!
Sadly I can't reproduce it.
Could you check that if you set a city explicitely the issue does not appear?
What unit have you selected?
Also could you tell me the browser you use and his version?
Does the console provide a line number?
Thanks!
from new-tab-moment.
Firefox 72.0.1
Selected Celsius units
Console does not provide a line number (this is one of the first times I have seen something like this)
Selecting a city does appear to fix the issue (the weather shows up and the console error does not appear)
Oddly the console error shows up at least a half second after the page finishes loading. Sometimes up to two seconds after.
from new-tab-moment.
Thanks for the info.
I think that the call to openweathermap.org fails with your geolocation.
I will add some traces as soon as I have the time, but I don't know if I can resolve this...
Just to be sure, does the extension have the permission to use the geolocation?
from new-tab-moment.
If you are familiar with Firefox Dev Tools (accessible by pressing F12), could you open a new tab, press F12, go to the network tab and click reload?
This will reload the page and normally display the request to openweathermap.
If the request is displayed, could you right-click on it and save as HAR and add the HAR file in this issue?
Thanks a lot!
from new-tab-moment.
To confirm the location permission, I disallowed the extension from geolocation, then enabled it when it asked for it again on the next reload. No change unfortunately.
There is no request being sent. When I manually enter a city, I can see a request to the OWM endpoint but I see no network activity when attempting to geolocate.
I am curious if this is related to privacy stuff Firefox recently added, I might play around and see if that makes a difference (stealth edit: it doesn't seem to be)
from new-tab-moment.
Sorry, I forgot a part before reload the page to check the request: can you go to the Storage tab and delete all items in the local storage first?
This will delete the cextensions's cache and a request will be sent.
from new-tab-moment.
Deleted local storage for the extension, reloaded page and still having the same issue, nothing appeared to change :/
I am going to reinstall the extension and see if that changes anything
from new-tab-moment.
The new version (0.5.1) is up, can you upgrade your local version, activate the debug mode in the options and check the console on a new tab?
Thanks!
from new-tab-moment.
I have checked on the firefox at work (68.4.1esr) and got a "navigator.geolocation is undefined" error when using new tabt moment without location.
On CanIUse it seems that the coordinates part of geolocation api had an absence during the 71 version of firefox (and I guess 68 esr), so it should not be your issue but I think I will explicit this error.
from new-tab-moment.
Yeah it looks like my issue is a personal problem, not tied to this extension. No other websites could find my location (I should have tried that first, my bad). I guess I need to work my way up the food chain...
from new-tab-moment.
At least it made me add some necessary traces and checks :)
Have you tried to restart firefox without addons?
Or to reinstall it?
from new-tab-moment.
I have release a new version of the addon which better handle weather and geolocation errors, I will now close this issue, thanks again for opening it! :)
For your problem, through my search on the subject I have found that it is possible to delete or override some key configuration on geolocation like these one on about:config
: geo.wifi.uri
, default value https://www.googleapis.com/geolocation/v1/geolocate?key=%GOOGLE_LOCATION_SERVICE_API_KEY%
.
from new-tab-moment.
Related Issues (14)
- Action required: Greenkeeper could not be activated 🚨
- Background Image HOT 3
- Support plural date/time HOT 4
- 000:34:24 displayed at night HOT 2
- Chromium Version HOT 11
- Custom JS Code Injection HOT 1
- Set as homepage HOT 1
- Multiple clocks HOT 4
- Update addon description on GitHub, Edge and Firefox HOT 1
- Update Lato font family HOT 2
- Request HOT 2
- Focus not set on awesome bar in fullscreen mode on Mac HOT 4
- Miss search engine HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from new-tab-moment.