eval returns undefined about cache-pug-templates HOT 9 CLOSED

@levani thanks for finding this core bug 👍 👏 I've gone ahead and patched it. I've also released a new version and deprecated all prior versions.

from cache-pug-templates.

@levani this is not a proper bug report - this code will not return undefined. It returns a function since it eval's the template string (which is a function stored as a string).

from cache-pug-templates.

Well, I may be missing something but

cache[__path__] = eval('function test() {}')

would result in cache[__path__] being undefined and creating test function in global scope...

from cache-pug-templates.

It is pug.cache[filename] = eval(compiledStr);, so pug.cache['some-file-name.pug'] = function test() {}.

from cache-pug-templates.

If there's a bug here that I'm not seeing please file a pull request and I can review

from cache-pug-templates.

Or perhaps you could write a test case that shows it fails?

from cache-pug-templates.

I will try to send PR but I'm not quite sure that I'm right yet :))

In redis, functions are stored as strings like this:

function template(locals) {
  var pug_html = ""
  ...
  return pug_html;
}

than you eval that string and assign it to an object property. Am I right?

Can you run this in browser console and see what's the value of o.file?

let o = {};
o.file = eval('function template() { var html="test html"; return html; }')

from cache-pug-templates.

You have to wrap it with parenthesis to get desired output:

const o = {};
o.file = eval('(function template() { var html="test html"; return html; })');

from cache-pug-templates.

Please download v0.0.8+, thanks!

from cache-pug-templates.