Giter Club home page Giter Club logo

Comments (3)

ztellman avatar ztellman commented on June 17, 2024 1

Sorry for the late response, I've been traveling. Thanks for catching this, since from or to could also potentially be null I've changed it to this:

public int hashCode() {
      if (hash == -1) {
        hash = Objects.hashCode(from) ^ Objects.hashCode(to) ^ Objects.hashCode(value);
      }
      return hash;
    }

from bifurcan.

ztellman avatar ztellman commented on June 17, 2024 1

There is some overhead with Objects.hash, but I believe my original rationale was to have equivalent hashes for undirected edges. On reflection, however, that doesn't also hold true for the equality check, so it probably makes sense to have DirectedEdge and UndirectedEdge classes.

from bifurcan.

michaelamaura avatar michaelamaura commented on June 17, 2024

Hey, great thanks for fixing this :-)

BTW: Great library, has been really helpful on a project I'm working on :-)

Just out of interest: Can you tell me the advantage from xoring the different hashCodes over calling Objects#hash? Is it the array allocation?

from bifurcan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.