Comments (7)
Hi @anouarchattouna, thanks for raising this. I've opened a ticket on our JIRA board to address this.
https://lacework.atlassian.net/browse/ALLY-951
from terraform-aws-cloudtrail.
Hi, thanks.
Is your Jira bord accessible publically?
from terraform-aws-cloudtrail.
It's not public, I've added the JIRA link only for internal purposes. We'll put any updates on the ticket here in the issue comments.
from terraform-aws-cloudtrail.
We're seeing the same issue and it poses a hard block on our development as we attempt to upgrade our AWS Terraform provider to ~> 4.9
.
module "aws_cloudtrail" {
source = "lacework/cloudtrail/aws"
version = "~> 2.0"
use_existing_cloudtrail = true
bucket_arn = "arn:aws:s3:::cloudtrail-${var.account_name}"
bucket_name = "cloudtrail-${var.account_name}"
bucket_sse_algorithm = "aws:kms"
bucket_sse_key_arn = module.cloudtrail.cloudtrail_kms_arn
lacework_integration_name = "${var.account_name}-ct"
sns_topic_encryption_enabled = false
sqs_encryption_enabled = false
use_existing_sns_topic = true
sns_topic_arn = aws_sns_topic.lacework_cloudtrail.arn
# An existing LACEWORK IAM role! Created by the `lacework_aws_config` module
use_existing_iam_role = true
iam_role_name = module.lacework_aws_config.iam_role_name
iam_role_arn = module.lacework_aws_config.iam_role_arn
iam_role_external_id = module.lacework_aws_config.external_id
}
Using the above code snippet we get the exact same error as shared in the issue. To be clear, we're upgrading from a working existing version ~> 0.2
to ~> 2.0
which fails. Here is our diff:
module "aws_cloudtrail" {
source = "lacework/cloudtrail/aws"
- version = "~> 0.2"
+ version = "~> 2.0"
use_existing_cloudtrail = true
bucket_arn = "arn:aws:s3:::cloudtrail-${var.account_name}"
bucket_name = "cloudtrail-${var.account_name}"
- bucket_enable_encryption = true
bucket_sse_algorithm = "aws:kms"
bucket_sse_key_arn = module.cloudtrail.cloudtrail_kms_arn
lacework_integration_name = "${var.account_name}-ct"
+ sns_topic_encryption_enabled = false
+ sqs_encryption_enabled = false
+
use_existing_sns_topic = true
sns_topic_arn = aws_sns_topic.lacework_cloudtrail.arn
Here is the error we are receiving:
Invalid count argument
on .terraform/modules/account-bootstrap.aws_cloudtrail/main.tf line 36, in resource "aws_kms_key" "lacework_kms_key":
36: count = local.create_kms_key
The "count" value depends on resource attributes that cannot be determined
until apply, so Terraform cannot predict how many instances will be
created. To work around this, use the -target argument to first apply only
the resources that the count depends on.
from terraform-aws-cloudtrail.
@dmurray-lacework is this ever coming? It was requested 8 months ago. I want to reuse the same KMS key I am already using for cloudtrail, S3, and SNS encryption and SQS.
from terraform-aws-cloudtrail.
As we start a new year I am sweeping all our open-sourced repositories and I found out we seem to have forgotten about y'all, I sincerely apologize for the insane delay on responding. I will be keeping an eye on this.
May I ask you to confirm that this PR implements this feature request? #102
from terraform-aws-cloudtrail.
Closing; both changes mentioned here have been addressed.
#84 - released in v2.1.1
#102 - To be released in v2.5.0
from terraform-aws-cloudtrail.
Related Issues (20)
- feat: Allow to filter SNS messages HOT 1
- feat: bucket_logs_enabled logs never expire
- bug: Integrate Existing Consolidated CloudTrail - terraform rerun deletes manually attached SNS topic HOT 2
- feat: CloudTrail log bucket denies HTTP requests HOT 3
- bug: support AWS provider v5.0
- TF modules pinning notes HOT 7
- Support for enable_log_file_validation
- feat: Lacework CloudTrail should send logs to CloudWatch HOT 1
- bug: [Action Required] S3 changes to bucket authorization are coming in October 2023 HOT 4
- Dependency conflicts with terraform-aws-cloudtrail
- How to implement this: .... HOT 1
- Outputs reference variables instead of resources created by this module HOT 2
- Support passing tags to S3 bucket HOT 1
- feat: Support s3 notifiers for syndicating cloudtrail to sns
- feat: Use existing S3 bucket for access logging HOT 1
- feat: add a required_providers version constraint HOT 1
- bug: support aws provider version ~> 4.0
- feat: Creating a trail for an organization HOT 2
- bug: Error when using use_existing_access_log_bucket = true HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-aws-cloudtrail.