Giter Club home page Giter Club logo

Comments (10)

CarlosPanarello avatar CarlosPanarello commented on August 21, 2024 1

@CarlosPanarello, thank you for your contribution!

I have a few considerations already:

  1. The english on the README should be double checked. There are some mistakes. And we can do that in Rubim's repo for now.
  2. We should rewrite the commit history as I am seeing some sensitive information in the commit log, namely you employee key:

image

  1. I don't see unit testing files. We should have a handful of tests just to make sure the lib have it's basic functions working properly.

@gilliardmacedo, could you see if their lib works as it should? And if the lib was written in a compliant way with how people are writing applications with Quarkus?

1 - I will review it in this weekend.
2 - I already corrected that.
3 - The test files is inside deployment project, there i made some tests for application_info and requests metrics, i need to add more tests for response-size and dependency metrics, right now they are in add_tests branch.

from big-brother.

eabili0 avatar eabili0 commented on August 21, 2024

@CarlosPanarello, thank you for your contribution!

I have a few considerations already:

  1. The english on the README should be double checked. There are some mistakes. And we can do that in Rubim's repo for now.

  2. We should rewrite the commit history as I am seeing some sensitive information in the commit log, namely you employee key:

image

  1. I don't see unit testing files. We should have a handful of tests just to make sure the lib have it's basic functions working properly.

@gilliardmacedo, could you see if their lib works as it should? And if the lib was written in a compliant way with how people are writing applications with Quarkus?

from big-brother.

eabili0 avatar eabili0 commented on August 21, 2024

@CarlosPanarello, please let me know in this thread when you finish tackling points 1 and 3. Thank you!

from big-brother.

eabili0 avatar eabili0 commented on August 21, 2024

@CarlosPanarello, any progress this week? Do you need any help?

from big-brother.

CarlosPanarello avatar CarlosPanarello commented on August 21, 2024

Yes, i just finished the tests. But i need to review the Readme.

from big-brother.

gilliardmacedo avatar gilliardmacedo commented on August 21, 2024

@abilioesteves I'm already using this lib. It works and is compliant.

from big-brother.

eabili0 avatar eabili0 commented on August 21, 2024

Thank you @gilliardmacedo! @CarlosPanarello, for this lib to be officially supported by labbsr0x, we require you to donate it to us. Just go to your repo's Settings, then click on Transfer and type the name of our github organization labbsr0x.

Once you do that, I'll close this issue and update Big Brother's documentation.

from big-brother.

eabili0 avatar eabili0 commented on August 21, 2024

@CarlosPanarello, if you want we can also add the quarkus-monitor as a third-party lib on our Readme.

from big-brother.

marcelorubim avatar marcelorubim commented on August 21, 2024

@abilioesteves I've just made the repository transfer. Thanks!

from big-brother.

eabili0 avatar eabili0 commented on August 21, 2024

Thank you @marcelorubim !

from big-brother.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.