Giter Club home page Giter Club logo

Comments (2)

koskimas avatar koskimas commented on June 4, 2024

Is this what you're after https://kyse.link/V6moD

from kysely.

jordanh avatar jordanh commented on June 4, 2024

@koskimas I'm running into two problems, the first I have a work around for but I wanted to raise it in case I am missing something.

This line:

   .leftJoinLateral(
        sql<{model: string}>`unnest(ARRAY[${sql.join(configuredModels)}]::varchar[])`.as<'v'>(
            'v(model)' as 'v'
        ),
        (join) => join.onTrue()
    )

Will render as:

 LEFT JOIN LATERAL unnest(ARRAY[$1, $2]::VARCHAR[]) AS "v(model)" ON TRUE

In the Postgres dialect, "v(model)" (note double quotes) won't create v.model (accessible with v.*, for example) rather, you'll et a column called v(model). Not the end of the world...one can work around that. Curious if there is a way to drop a literal as?

Second thing I'm running into. I ended up cleaning up my code a bit and using RawBuilder<T> to implement a convenience method:

  function unnestedArray<T>(value: T): RawBuilder<T> {
    if (!Array.isArray(value)) {
      throw new TypeError('Value must be an array')
    }

    return sql`unnest(ARRAY[${sql.join(value)}]::varchar[])`
  }

  const batchToQueue = (await pg
    .selectFrom('EmbeddingsMetadata as em')
    .selectAll('em')
    .leftJoinLateral(unnestedArray(configuredModels).as('model'), (join) => join.onTrue())
    .leftJoin('Team as t', 'em.teamId', 't.id')
    .select('model') // <-- Typescript error 

The TypeScript error I get is:

No overload matches this call.
  Overload 1 of 3, '(selections: readonly SelectExpression<DB & { em: EmbeddingsMetadata; } & { model: (string | null)[]; } & { t: Nullable<Team>; }, "em" | "model" | "t">[]): SelectQueryBuilder<...>', gave the following error.
    Argument of type 'string' is not assignable to parameter of type 'readonly SelectExpression<DB & { em: EmbeddingsMetadata; } & { model: (string | null)[]; } & { t: Nullable<Team>; }, "em" | "model" | "t">[]'.
  Overload 2 of 3, '(callback: SelectCallback<DB & { em: EmbeddingsMetadata; } & { model: (string | null)[]; } & { t: Nullable<Team>; }, "em" | "model" | "t">): SelectQueryBuilder<...>', gave the following error.
    Argument of type 'string' is not assignable to parameter of type 'SelectCallback<DB & { em: EmbeddingsMetadata; } & { model: (string | null)[]; } & { t: Nullable<Team>; }, "em" | "model" | "t">'.
  Overload 3 of 3, '(selection: SelectExpression<DB & { em: EmbeddingsMetadata; } & { model: (string | null)[]; } & { t: Nullable<Team>; }, "em" | "model" | "t">): SelectQueryBuilder<...>', gave the following error.
    Argument of type '"model"' is not assignable to parameter of type 'SelectExpression<DB & { em: EmbeddingsMetadata; } & { model: (string | null)[]; } & { t: Nullable<Team>; }, "em" | "model" | "t">'.ts(2769)

This is strange to me as I see "model" in the types right there but I haven't walked the source yet to grok why this TS error is happening.

Anyhow, the first bit is the thing that's more interesting. Definitely a corner case. If you don't care to address it I am fine just working around it for now.

from kysely.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.