Giter Club home page Giter Club logo

Comments (6)

Kyon147 avatar Kyon147 commented on June 30, 2024

I assume you are getting an app rejection?

I've seen this happen with Blade because of the redirect that happens after OAUTH to the authenticate/token route. Shopify only want users to be directed to the app homepage but blade needs that route in between to get the JWT token.

There's no current solution that I know of apart from making your app run like an SPA using Livewire or similar.

Edit: I do see on a test version that the headers are not being set in the latest version. It looks like the middleware is not firing although it is being registered.

from laravel-shopify.

mohd-baquir-qureshi avatar mohd-baquir-qureshi commented on June 30, 2024

from laravel-shopify.

Kyon147 avatar Kyon147 commented on June 30, 2024

I've created a new PR which seems to fix the issue. If the tests pass, I will release a new patch later on.

#56

image

from laravel-shopify.

joeelia avatar joeelia commented on June 30, 2024

@mohd-baquir-qureshi, if you want to fix this before the patch, you can add this line of code to your kernel.php under the 'web' middleware group:

\Osiset\ShopifyApp\Http\Middleware\IframeProtection::class

Example:
File: app/Http/Kernel.php

'web' => [
            \App\Http\Middleware\EncryptCookies::class,
            \Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse::class,
            \Illuminate\Session\Middleware\StartSession::class,
           ............
            \Osiset\ShopifyApp\Http\Middleware\IframeProtection::class, //<----- Add this at the end
        ], 

from laravel-shopify.

joeelia avatar joeelia commented on June 30, 2024

@mohd-baquir-qureshi the PR is out, and you can update the package or you cant use my solution above. If the issue is resolved then close this bug..

from laravel-shopify.

Kyon147 avatar Kyon147 commented on June 30, 2024

This should be fixed now in 17.4.3 so closing but re-open if it still happens after upgrading.

from laravel-shopify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.