Giter Club home page Giter Club logo

Comments (8)

yasir-naseer avatar yasir-naseer commented on September 13, 2024

image

i checked the app bridge configuration, seems like the host parameter is not getting picked

from laravel-shopify.

Kyon147 avatar Kyon147 commented on September 13, 2024

Hi @yasir-naseer

This can be fixed by moving to 17.4.1 as the issue was on the blade template version where the auth token redirect that happens never got the host param from the VerifyShopify middleware redirect.

from laravel-shopify.

jackwefullfill avatar jackwefullfill commented on September 13, 2024

hi @Kyon147

so for now, blade templates still have to use shopOrigin right?

from laravel-shopify.

Kyon147 avatar Kyon147 commented on September 13, 2024

Hi @jackwefullfill

17.4.1 still uses host it just fixes a bug where it was not being passed through the auth properly. shopOrigin is no longer used as it is being deprecated by Shopify.

from laravel-shopify.

jackwefullfill avatar jackwefullfill commented on September 13, 2024

hi @Kyon147 , thanks for the explanation, so what I wanted to ask is that in order to use the blade template, we need to wait for the 17.4.1 version release. only then the app will become compatible new shopify domain right?

from laravel-shopify.

Kyon147 avatar Kyon147 commented on September 13, 2024

Yeah that is right, 17.4.1 will be compatible with the new admin domain but will also work for the older domain too.

from laravel-shopify.

yasir-naseer avatar yasir-naseer commented on September 13, 2024

hi @Kyon147

after upgrading to 17.4.1. The issue of app not loading is fixed, since now im getting the host parameter in app bridge setup (which is all good now)

but when i redirect to some other page, the host parameter is lost again and the app starts keep loading, am i missing something?

Here is how my tag look like

<a class="nav-link" href="{{ \Illuminate\Support\Facades\URL::tokenRoute('home') }}" >Home</a>

153f5f3d-d7f7-49a1-b35d-0b6e9c389d8d.webm

from laravel-shopify.

Kyon147 avatar Kyon147 commented on September 13, 2024

@yasir-naseer Shopify have explicitly said, if you are running a multipage app you need to manually pass the host param to all pages.

image

The package does not do this automatically, so you will need to remember to pass to host from page to page.

from laravel-shopify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.