Giter Club home page Giter Club logo

Comments (10)

mforbes avatar mforbes commented on July 23, 2024

I am fine with any license.

from nbstripout.

minrk avatar minrk commented on July 23, 2024

MIT/BSD is always my preference. My original gist is Public Domain, so do whatever you prefer.

from nbstripout.

mforbes avatar mforbes commented on July 23, 2024

The only issue I can imagine right now is that the best solution for using this mercurial might be as an extension, which would probably have to be compatible with GPLv2. This would preclude me from including an extension with this project, but I think that is reasonable. Such an extension should probably be distributed on its own anyway.

http://www.third-bit.com/2010/04/12/the-chilling-effect-of-the-gpl.html

from nbstripout.

kynan avatar kynan commented on July 23, 2024

Given that MIT (== X11) is GPLv2 compatible I'll go for that.

from nbstripout.

mforbes avatar mforbes commented on July 23, 2024

It is not backwards compatible: i.e. one still cannot include a mercurial extension here, but as I said, I don't think that is a real problem. I have updated PR #2 to include the MIT license and some classifiers.

One issue: if you install this from PyPI, I don't think that the git filters will get installed. They probably need to be installed in a MANIFEST.in file. Also, do you have any good idea how to make these accessible to users when the package is installed from PyPI? In my project I added a script that can be sourced to set the users environmental variables. Do you have a better suggestion?

from nbstripout.

kynan avatar kynan commented on July 23, 2024

Git filters are per repository and they should not be installed globally when one installs nbstripout. So this is intended behaviour and I don't think there is an issue.

from nbstripout.

mforbes avatar mforbes commented on July 23, 2024

I can never remember where things are, so like to be able to run or source a single command mmf_setup which does whatever needs to be done to install hooks etc. in a repository. Thus, I thought it might be useful to include the script in the manifest so it can be programmtically installed by a script from os.path.basename(nbstripout.__file__) for example.

from nbstripout.

kynan avatar kynan commented on July 23, 2024

I don't think I fully understand your use case @mforbes. For a Git repository you simply run nbstripout install to install the hook. I suppose we could augment this task to also work in Mercurial repositories (we're already testing whether we're inside a Git repository, so this could simply be extended).

from nbstripout.

kynan avatar kynan commented on July 23, 2024

We now have an MIT license (added by #2).

from nbstripout.

mforbes avatar mforbes commented on July 23, 2024

Ah. Okay, I think I understand now. I will see if I can do something similar with mercurial.

from nbstripout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.