Comments (9)
@geggo Thanks for reporting this! I just did a simple test with a notebook with one code cell with some unicode text in a string and I didn't get any failures. Could you attach the notebook you get the failure with?
from nbstripout.
Thanks for looking at this issue. A simple notebook that shows the problem is: test_unicode.ipynb
from nbstripout.
Nope, sorry, works just fine for me (Python 2.7 on Linux x64). Could this be a Mac or Anaconda issue?
from nbstripout.
@geggo Tried with Anaconda too, no issue either. I'll add your notebook as a regression test, let's see what Travis has to say.
from nbstripout.
Aha, hang on! This is irritating! I do get the error iff I redirect the output to file, not if I just let it go to the terminal. How is that even possible? Redirection should be purely handled by the shell!
from nbstripout.
Your suggested fix works, so I'll pull that in, thanks for this!
from nbstripout.
@geggo: Released in 0.2.3!
from nbstripout.
For the record: redirection can make a difference because code can detect whether the output is a terminal or a pipe (this is how e.g. ls
shows files in nice columns when used interactively). In Python's case, its guess of the encoding to use for output is different when output is being piped to a file.
from nbstripout.
@takluyver thanks for highlighting! I did read up on the topic after fixing this but failed to clarify.
from nbstripout.
Related Issues (20)
- Should be agnosting on trailing blank lines HOT 9
- [Feature Request] Process Folders (Batch / Bulk) HOT 1
- Doesn't strip out pycharm metadata HOT 9
- New release HOT 2
- Replace cram with prysk HOT 2
- Read config from `setup.cfg` HOT 1
- Option to error on cell outputs exceeding `--max-size` HOT 4
- It is recommended to remove pytest-runnner from setup_requires in setup.py HOT 4
- Strip output_type=stderr only, with keep_output? HOT 4
- Possible nbstripout-fast integration HOT 6
- Prevent committing notebooks with errors in cell outputs HOT 6
- Specifying Python executable path in `nbstripout --install`
- 'nbstripout' is not recognized as an internal or external command, operable program or batch file. HOT 2
- Not compatible with `pre-commit-hooks/pretty-format-json` hook HOT 4
- `git config filter.nbstripout.extrakeys ` support for `attachments`? HOT 4
- Support setting defaults for command line arguments via git config
- No valid notebook detected HOT 4
- required = true by default or make doc more explicit about it HOT 5
- Support git-filter-repo HOT 2
- Any examples for --keep-id option? HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nbstripout.