Comments (7)
Thanks for the report, I've added it to the issues list at the Binwalk project
page (http://binwalk.googlecode.com).
I'd like to reproduce the bug - can you tell me exactly which firmware image
caused the seg fault? I tried against
http://dd-wrt.com/routerdb/de/download/D-Link/DIR-615/C1/dir615c1-firmware.bin/3
588 but could not reproduce the issue.
Original comment by [email protected]
on 25 Nov 2011 at 4:31
- Changed state: Accepted
from firmware-mod-kit.
Hi,
some more info:
I am using gcc (Debian 4.6.2-4) 4.6.2
The firmware extracted is
http://dd-wrt.com/routerdb/de/download/D-Link/DIR-615/D3/dir615d-ddwrt-webflash.
bin/3829 (think the D3 version is germany specific (?))
My kernel is x86_64 (Linux super 3.1.0-1-amd64 #1 SMP Mon Nov 14 08:02:25 UTC
2011 x86_64 GNU/Linux)
I attached the valgrind log and the log of the extract-ng.sh script.
Original comment by [email protected]
on 26 Nov 2011 at 1:09
Attachments:
from firmware-mod-kit.
By the way, just noticed that the binwalk log in fmk/logs/binwalk.log seems to
look fine ...
Original comment by [email protected]
on 26 Nov 2011 at 1:13
from firmware-mod-kit.
Thanks for the additional information. I tested the firmware image on Ubuntu
10.04 Linux ubuntu 2.6.32-33-generic #71-Ubuntu SMP Wed Jul 20 17:27:30 UTC
2011 x86_64 GNU/Linux) with gcc 4.4.3 (Ubuntu 4.4.3-4ubuntu5), but binwalk ran
without error.
I can easily apply the patch, it's simple enough, but I'd really like to
understand what is causing the NULL string. The code explicitly checks the
'type' string pointer for NULL, and does not call print if type is NULL, so I'm
not sure how a NULL string is getting passed to vfprintf in the first place.
Original comment by [email protected]
on 26 Nov 2011 at 2:20
from firmware-mod-kit.
Maybe it's something specific with my gcc version. Also you can recognize this
maybe because the patch is rather stupid. The print function works with null
strings if only one %s is present in the format string, if there are others it
seems to fail. So splitting up the print into two fixes the crash problem for
me, but I do not understand why... also had the same thoughts as you as there
are explicit checks for null ...
Original comment by [email protected]
on 26 Nov 2011 at 4:49
from firmware-mod-kit.
I could be a gcc issue, not sure - definitely odd though. In any case, if
splitting the print statement into two print statements fixes the issue I'll do
that as it won't hurt anything else. I'll apply the changes back to the main
binwalk project as well. Thanks!
Original comment by [email protected]
on 26 Nov 2011 at 5:12
from firmware-mod-kit.
Upgraded binwalk to v0.4.1 which fixes this issue.
Original comment by [email protected]
on 3 Dec 2011 at 3:46
- Changed state: Fixed
from firmware-mod-kit.
Related Issues (20)
- CRC update failed. Firmware header not supported; firmware checksums may be incorrect.
- Firmware header not supported; firmware checksums may be incorrect.
- wdr3600v1 firmware cannot be unpacked HOT 1
- Extracting 0 bytes of header image at offset 0 HOT 1
- Failure building image.
- Can this firmeware be extracted? HOT 2
- jffs2 big endian problem
- new binwalk HOT 1
- CramFS extraction failed due to missing cleaning up
- Can't unpack Zyxel NWA-3100 firmware HOT 1
- Wrong build
- uncramfs-lzma stops after successfully decoding the first block
- Extracted firmware and then tried to rebuild it and it became larger, probably because it didnt use lzma for recompress. HOT 1
- Image fault when builidng Tomato for RT-AC68U HOT 3
- Cannot extract firmware
- Issue in extracting squashfs filesystem
- Firmware Image Generated Different from Original when nothing changed for its extracted contents
- Failed to create new file system
- Can not extract Huawei HG655b-B025 firmware
- after edit ddwrt-gui's asp file,install error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from firmware-mod-kit.