Middleware toggle about apicache HOT 4 CLOSED

Hmmm. That's because the middleware toggle is executed before your route logic. It's 200 at the time of evaluation, then gets set to 500 just before final send. I'll have to give some thought to the best solution around this behavior! ~ Kevin @krwhitley.com On Mon, Jul 31, 2017 at 4:49 AM, Mark Lee <[email protected]> wrote: I think I'm also missing something here... const router = require('express').Router() const apicache = require('apicache') const cache = apicache.middleware const statusOkOrNotFound = (req, res) => { console.log("check status " + res.statusCode) return res.statusCode === 200 || res.statusCode === 404 } const cacheValid = cache('5 minutes', statusOkOrNotFound) router.get('/api/test', cacheValid, (req, res) => { console.log("API request, send fake error") res.status(500).send("fake error") return } When I execute this request, I see this trace in unexpected order: check status 200 API request, send fake error And this response: HTTP/1.1 500 Internal Server Error x-powered-by: Express cache-control: max-age=300 The only difference I see between this and your example is I do: const router = require('express').Router() router.get(...) And your example shows: const app = require('express') app.get(...) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub [#80 (comment)] , or mute the thread [https://github.com/notifications/unsubscribe-auth/AA00iNZfiDyXdiKTnERiFE0xY3Wrq1TGks5sTaM-gaJpZM4MwTOu] .