Giter Club home page Giter Club logo

Comments (5)

benjaminwinger avatar benjaminwinger commented on September 25, 2024

We're using the upload-artifact action, which according to its documentation does not preserve file permissions (not all zip tools handle permissions, as permissions were an extension of the format as far as I'm aware). There is an open issue.

I think all that should be necessary is to manually create the zip archive with a tool that supports permissions, and upload that.

from kuzu.

mewim avatar mewim commented on September 25, 2024

Instead of creating zip file, let's just switch to tar.gz, which should preserve file permissions robustly. However, as per https://github.com/actions/upload-artifact?tab=readme-ov-file#zip-archives:

When an Artifact is uploaded, all the files are assembled into an immutable Zip archive. There is currently no way to download artifacts in a format other than a Zip or to download individual artifact contents.

There are also several related issues: actions/upload-artifact#109 and actions/upload-artifact#39.

So this means that the build pipeline will create a tar.gz, but it will be double-zipped by upload-artifact. The person responsible for releasing needs to unzip the artifact and upload the enclosed tar.gz file.

from kuzu.

prrao87 avatar prrao87 commented on September 25, 2024

Does this work on all OSes without any issues? If so, we should properly document it.

from kuzu.

mewim avatar mewim commented on September 25, 2024

Does this work on all OSes without any issues? If so, we should properly document it.

tar.gz should be supported by macOS and most Linux distros by default. For Windows, we will keep publishing zip. I do not have a Windows machine to test right now, but I think Windows also does not require setting permission for exe files (@acquamarin and @benjaminwinger can comment)?

from kuzu.

benjaminwinger avatar benjaminwinger commented on September 25, 2024

No, windows doesn't have executable permissions. .exe files are always executable.

from kuzu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.