Use upstream libui-node about proton-native HOT 12 CLOSED

Ok looks good. Did you increment the version a d publish to npm because I didn't see that in your diffs.

from proton-native.

@parro-it ?

from proton-native.

Just released 0.1.0 on npm.
I'm testing now with my fork of proton... I will publish a PR here.

from proton-native.

@parro-it This can get you started: mischnic@d42ab2b

from proton-native.

Oh great! if you open a PR here of your forks I'll push further changes there (I don't know if I need specific permission to do so)

from proton-native.

Does libui not need to be initialized anymore ? I noticed that was taken out in the fork.

from proton-native.

Any idea why I get Electron installed when I npm install proton?

Electron is not a direct proton dependency AFAIK

from proton-native.

Does libui not need to be initialized anymore ? I noticed that was taken out in the fork.

No, init is now called automatically the first time you require the module. We'll have to update docs & examples

from proton-native.

Not of proton, but the react dev tools:

@kusti8 How does integration with the dev tools work? This doesn't:

proton-native/src/render/index.js

Lines 17 to 22 in e10f481

	// DesktopRenderer.injectIntoDevTools({
	// bundleType: 1,
	// version: '0.1.0',
	// rendererPackageName: 'custom-renderer',
	// findHostInstanceByFiber: DesktopRenderer.findHostInstance
	// })

PR: #57

from proton-native.

from proton-native.

I tried commenting out these lines and the dev tools started by npx react-dev-tool didn't connect to proton.

from proton-native.

It's working 🎉

@mischnic I pushed to your fork

from proton-native.