Passphrase required about shakedex HOT 3 CLOSED

Good point - I will update the passphrase method to support empty passphrases if necessary.

Re: the passphrase - I'll look into this. The code should be asking for a passphrase wherever we create a keyring, which is required to create the auction TXs.

from shakedex.

Ohhhh I see, you are generating a new key pair just for the swap wallet and storing it in a local DB, I thought it was coming from the associated hsd wallet as well. Hmmm interesting. Since this is the case, you may want to emphasize to the user to backup the DB, or actually offer them a seed phrase to back up on wallet initialization. I guess since you are signing a funky script you probably can't use the usual wallet API so it makes sense that shakedex generates new keys.

from shakedex.

Yea, we have to use a special key to sign the script. I've added this to the docs.

from shakedex.