Comments (6)
How did you get that version? I assume with the version
pkg? Well, it works as designed: the version package was designed to report the KubeVirt version, and values are set during the build process via ldflags. The values you see are the default values.
So even when you update your build process to set those values, it would report the version of your own component, and not client-go's version. Not sure if we can/want to support the latter. @rmohr wdyt?
You can get KubeVirt's server version if that helps:
virtClient, _ := kubecli.GetKubevirtClient()
info, _ := virtClient.ServerVersion().Get()
from client-go.
Not sure if we can/want to support the latter.
Yep I don't think it makes much sense to support this.
@slintes can we exclude anything related to version
from client-go, when we sync with staging?
from client-go.
can we exclude anything related to version from client-go, when we sync with staging?
I think just excluding something won't work (well, it wouldn't be nice at least imho). But we could refactor it to only keep the version.Info struct in client-go (it's used in kubecli for getting the server's version), and move everything else back to kubevirt.
from client-go.
@slintes yep, you basically got it. Looks like I misunderstood the purpose of the version package in the client-go module.
I'd like a way to report (= print in the logs) the release of client-go
which my binary has compiled in; I can think of few workarounds which don't require any change, so we can close this issue.
from client-go.
if you have a workaround which we could easily add to client-go, let us know 🙂
/close
from client-go.
@slintes: Closing this issue.
In response to this:
if you have a workaround which we could easily add to client-go, let us know 🙂
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from client-go.
Related Issues (19)
- where is the documentation ? HOT 4
- Replace glog to klog HOT 4
- unknown revision v0.0.0 HOT 5
- undefined: log.Context on go vet HOT 1
- GetKubevirtClientFromRESTConfig should not change the content of parameter HOT 2
- kubevirt.io/client-go/kubecli is not compatible with k8s.io/client-go v0.21.0 HOT 8
- how to watch vm status change HOT 5
- execute command:virtctl addvolume return:error adding volume, the server could not find the requested resource HOT 4
- Having issues pulling package HOT 5
- Add examples HOT 5
- Recommendation to use client-go with k8s.io v0.26.0 HOT 6
- Cannot use MockKubevirtClientInstance HOT 8
- k8s.io/client-go at latest version v0.27.4 but not at required version v12.0.0+incompatible HOT 16
- create datavolume err: v1.GetOptions is not suitable for converting to "kubevirt.io/v1" HOT 4
- run example failed HOT 2
- Project missing LICENSE file. HOT 1
- Not Compataible | kubevirt client-go in a code-base that uses Kubenetes 1.18.8 dependencies. HOT 2
- client-go support informer
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client-go.