add append hook about loadjs HOT 11 OPEN

Glad you like it! Do you want to modify the PR?

In terms of the name, maybe we should keep before for backwards compatibility.

from loadjs.

The append hook looks useful but the name feels ambiguous. Did you consider any other names? beforeAppend? insert?

from loadjs.

@sourcec0de - do you have any thoughts on the naming convention? I'm leaning towards calling the attribute insert instead of append.

from loadjs.

@amorey I think that makes sense.
I can't think of a way to easily indicate that it's overriding the insertion. I kind of like beforeInsert

from loadjs.

Ok, thanks for the feedback. One problem with beforeInsert is that it isn't clear that the method overrides the DOM insertion method.

from loadjs.

Sure, in that case i think append makes sense.

from loadjs.

Once it's decided would you like me to update my PR?

from loadjs.

Sure, if you can update the PR that would be great. I thought you preferred insert to append...

from loadjs.

Here's another idea - how about combining the before and append callbacks into one method? If the before callback returns false then we can bypass the default insertion method at L143:
https://github.com/muicss/loadjs/blob/master/src/loadjs.js#L143

If we decide to do it this way then I think beforeInsert would be an appropriate name.

from loadjs.

from loadjs.

@sourcec0de The latest version of LoadJS (v3.5.0) has support for this functionality. Just return false in the before callback to bypass the default DOM insertion mechanism:
https://github.com/muicss/loadjs
https://www.npmjs.com/package/loadjs

Let me know if you run into any issues using the new feature.

from loadjs.