Comments (13)
I think the hard part of this would be the same as why we can't move validation into staging. Some of those fields may not belong in staging like pod validation opts.
+1
This function relies /pkg/api/v1/pod
and PodResourcesOptions
and both of them are not in staging
.
I'm +1 for having this but I think maybe we need to move both /pkg/api/v1/pod
and /pkg/api/v1/resource
to component-helpers
from kubernetes.
I've created #124609 to simply move both /pkg/api/v1/pod
and /pkg/api/v1/resource
to component-helpers
.
To fully solve this problem, we need to replace the function pointed out in #124537 (comment) with the function in component-helpers
.
I tend to replace them after #124609 if we all agree the movement, to reduce the complexity of #124609.
from kubernetes.
/sig scheduling
from kubernetes.
cc @liggitt for any concerns
from kubernetes.
+1, I think this would be helpful to have as a generic library function to generate resource requirements for pods.
from kubernetes.
/sig node
from kubernetes.
I think the hard part of this would be the same as why we can't move validation into staging. Some of those fields may not belong in staging like pod validation opts.
from kubernetes.
This one is easier. It's based on versioned types.
from kubernetes.
We also wanted to implement this: #115643
Those are not mutually exclusive, just pointing that for many use cases reading pod status may be a better idea.
from kubernetes.
btw, this function by itself was a result of the big effort: #115367
from kubernetes.
I think kubectl also faces this problem:
and also in admission:
We now maintain this same function in three different places, I'll try if we can merge these three function into one in pkg component-helpers
.
from kubernetes.
/triage accepted
Reusing the same code in scheduler and kubelet would be highly beneficial in quite a few flows
from kubernetes.
/assign
from kubernetes.
Related Issues (20)
- Kubernets service not distributing traffic in equally , seeing imbalance in traffic . HOT 14
- Publish Markdown for OpenAPI field descriptions using an extension HOT 4
- Enhancement: allow to filter what fields to return from the API HOT 3
- [Failing Test] ci-crio-cgroupv1-node-e2e-conformance (Swap Tests) HOT 3
- [Flaking Test] integration-master (goroutine leak detection) HOT 6
- [Flaking Test] ci-node-e2e (Container Lifecycle) HOT 11
- Migrate existing features to versioned feature gate HOT 4
- verification machinery for compatibility version HOT 3
- [Flaking Test] TestLog/stateful_set_logs_with_all_pods HOT 4
- Pod deleted during image pull still starts HOT 10
- ValidatingAdmissionPolicy objects have different runtime type compared to CRDValidationRules HOT 8
- `kube-proxy`'s `--healthz-bind-address` should support IPv4 and IPv6 simultaneously (dual stack) HOT 24
- Bug: securityContext appArmorProfile unconfined not working with containerd HOT 2
- The old pod log file is not deleted from the /var/log/pods/ directory HOT 13
- Job controller reports the count of terminating pods with unnecessary delay HOT 4
- tracking issue; bump pause to 3.10 HOT 4
- kubernetes-sigs / scheduler-plugins go.mod Error HOT 3
- post-kubernetes-push-image-pause failed to publish version 3.10 HOT 15
- Failure cluster [6bc9e9c5...] HOT 1
- Apiserver log "Forcing xxx watcher close due to unresponsiveness" meaning consultation HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kubernetes.