Giter Club home page Giter Club logo

Comments (7)

dims avatar dims commented on May 23, 2024 2

i'd make it even more specific (like the version file or something!)

from kubernetes.

dims avatar dims commented on May 23, 2024 1

any presubmit has to be optional please! (folks who need it should run it by hand)

from kubernetes.

mkumatag avatar mkumatag commented on May 23, 2024

/sig testing

from kubernetes.

mkumatag avatar mkumatag commented on May 23, 2024

/triage accepted

from kubernetes.

mkumatag avatar mkumatag commented on May 23, 2024

any presubmit has to be optional please! (folks who need it should run it by hand)

or may be trigger the job when change happens in that dir? like we are doing it here

from kubernetes.

BenTheElder avatar BenTheElder commented on May 23, 2024

This is going to have skew with the cloudbuild anyhow, we can't securely give presubmit access to the production build env.

I think it's OK if we merge something and the build fails, and usually we can tell with ... code review.
The new images aren't used until after manual promotion anyhow. We do not use these from staging.

from kubernetes.

mkumatag avatar mkumatag commented on May 23, 2024

This is going to have skew with the cloudbuild anyhow, we can't securely give presubmit access to the production build env.

Big NO for cloudbuilds, wondering if we can use just a docker build.

I think it's OK if we merge something and the build fails, and usually we can tell with ... code review.

The new images aren't used until after manual promotion anyhow. We do not use these from staging.

from kubernetes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.