Giter Club home page Giter Club logo

Comments (3)

liggitt avatar liggitt commented on May 26, 2024

This code is mutating the package-level schemebuilder:

kubernetes/staging/src/k8s.io/apiserver/pkg/endpoints/discovery/aggregated/handler.go

Lines 152 to 155 in 55e4172

func NewResourceManager(path string) ResourceManager {
scheme := runtime.NewScheme()
// Register conversion for apidiscovery
apidiscoveryv2.SchemeBuilder.Register(apidiscoveryv2conversion.RegisterConversions)

I think it should be adding the conversions to the local scheme instead:

func NewResourceManager(path string) ResourceManager {
	scheme := runtime.NewScheme()
	utilruntime.Must(apidiscoveryv2.AddToScheme(scheme))
	utilruntime.Must(apidiscoveryv2beta1.AddToScheme(scheme))
	// Add conversion for apidiscovery
	utilruntime.Must(apidiscoveryv2conversion.RegisterConversions(scheme))

from kubernetes.

liggitt avatar liggitt commented on May 26, 2024

Fixed in #123634 (found several instances)

from kubernetes.

leilajal avatar leilajal commented on May 26, 2024

/triage accepted

from kubernetes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.