Comments (18)
Thanks for keeping the ball rolling. Looking forward to the next iteration.
from git-sync.
Hey @andjelx are you working on this ?
I just started doing it today because, well having a very similar usecase..
https://github.com/emirozer/git-sync/commit/5aaffadae52ee201ff40dc78704373453ec12880
Its initial work only at the moment, so I'm gonna test & see if i can add something to the testing process about the hook as well. Do let me know if you already made progress?
from git-sync.
Actually I made it, it’s in my fork, but haven’t received any feedback here to raise a PR :(
from git-sync.
People are busy I guess :) why not raise the PR and discuss there, since it is going the be a very small change-set without side-effects to actually syncing ?
Ofc I'm not a maintainer so, no disrespect 🍻
from git-sync.
Initiated: #85
from git-sync.
Commented on the PR. Future feature issues might take a bit longer to respond due to priorities.
from git-sync.
Sorry, it's been a hellish few weeks for me. Will look at the PR. In general I don't have a problem with this, but I'd prefer fewer flags. What about something like --webhook='{"url": "http://localhost:1234/reload", method="POST", success=200}'
- that block can be parsed as JSON, with unspecified keys having default values.
Unclear if success should be a specific code or a range.
from git-sync.
@thockin
Your flags approach a good idea, but I just followed the same approach as in original code + technically passing ENV vars might be easier to use with K8 Deployments.
For now: success code is one code (not a range)
from git-sync.
@thockin What if we would go with existing approach with flags, then migrate to your approach ?
from git-sync.
@andjelx that would already introduce them to the user and make the "upgrade" not backwards compatible.
from git-sync.
@stp-ip good point... I need then to dig more into Go then (as mostly on Python) how to process JSONs
from git-sync.
@stp-ip, @thockin I have updated PR. Could you please have a look?
from git-sync.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
from git-sync.
/remove-lifecycle stale
from git-sync.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
from git-sync.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
from git-sync.
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen
.
Mark the issue as fresh with /remove-lifecycle rotten
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
from git-sync.
@fejta-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen
.
Mark the issue as fresh with/remove-lifecycle rotten
.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from git-sync.
Related Issues (20)
- GitLab via ssh key HOT 3
- How to disable commit hash in the target folder? HOT 2
- Allow the submodule functionality for repos copied using vcs tool HOT 1
- Temporarily missing files when using $GITSYNC_LINK HOT 4
- Remediate security vulnerabilities on 4.1.0 HOT 5
- High vulnerability CVE-2023-6246 and CVE-2023-6779 HOT 1
- Issue with PYTHONPATH Resolution in git-sync 4.0.0 HOT 2
- v4 slack webhook HOT 6
- exechook behavior HOT 4
- Remediate 4.2.2 security vulnerabilities HOT 1
- Support GitHub App authentication HOT 7
- TODO: infra to make #878 work HOT 1
- Curious about real example raising race condition when using v3 HOT 1
- exechook working HOT 8
- TODO: shellcheck test_e2e.sh and test_git.sh HOT 5
- /bin/sh: ./build/test.sh: not found
- test_e2e.sh: use `local` for all variables defined inside functions HOT 2
- git-sync Multiple Vulnerabilities HOT 3
- how can put specific html folder from my git repo to nginx pod? HOT 2
- git-sync produced an intermediate file,the path of command is wrong HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-sync.