Comments (11)
ursuad
commented on August 19, 2024
Maybe an option here would be to introduce a hook which will get triggered once the pull (update) is successful?
For example calling a configurable REST endpoint ( notify ) once the update is complete. This way, it would be really easy to create a wrapper around third party tools that want to use the git-sync functionality.
The third party tools would get notified once the update is complete. This would partly eliminate the need for non atomic behaviour.
from git-sync.
thockin
commented on August 19, 2024
That could be workable
…On Tue, Apr 4, 2017 at 10:07 AM, Adrian Ursu ***@***.***> wrote:
Maybe an option here would be to introduce a hook which will get triggered
once the pull (update) is successful?
For example calling a configurable REST endpoint ( notify ) once the
update is complete. This way, it would be really easy to create a wrapper
around third party tools that want to use the git-sync functionality.
The third party tools would get notified once the update is complete. This
would partly eliminate the need for non atomic behaviour.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVI-2Cm3e5bSGJRTWrSTlqZXug9ffks5rsnjKgaJpZM4MlNrv>
.
from git-sync.
stp-ip
commented on August 19, 2024
Do we want to add triggering to git-sync?
What trigger should be used? http, touch ready.file, etc.?
Should we still provide a non atomic option?
from git-sync.
thockin
commented on August 19, 2024
I'd be OK with adding triggers - both HTTP get and file touch seem OK. I
would not add non-atomic, unless there's significant pain being caused by
symlinks. I haven't looked closely.
…On Tue, Apr 4, 2017 at 11:44 AM, Michael Grosser ***@***.***> wrote:
Do we want to add triggering to git-sync?
What trigger should be used? http, touch ready.file, etc.?
Should we still provide a non atomic option?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVJiR82Zq0iporS06mrEpAHiYIZnkks5rso-NgaJpZM4MlNrv>
.
from git-sync.
stp-ip
commented on August 19, 2024
One of the pain points of symlinks are programs using notify "different" following symlinks and not checking for symlink changes itself. hugo for example.
from git-sync.
thockin
commented on August 19, 2024
I am fine with non-atomic mode, if people really can't work around it, but
maybe we could fix Hugo ?
…On Tue, Apr 4, 2017 at 12:14 PM, Michael Grosser ***@***.***> wrote:
One of the pain points of symlinks are programs using notify "different"
following symlinks and not checking for symlink changes itself. hugo for
example.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVMsFSVJv1OqIkV3vPRPwLPzqFMp3ks5rspaJgaJpZM4MlNrv>
.
from git-sync.
japettyjohn
commented on August 19, 2024
This would help when the folder becomes the CWD of the app for Go, not sure if this is the same problem in Hugo. In my case the symlink is dereferenced which then leads to explosions when it references a relative file from the non-existent folder.
Another option would be to replace the old folder with a symlink to the new folder. The notification should still be added so things can get reloaded as needed.
from git-sync.
fejta-bot
commented on August 19, 2024
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Prevent issues from auto-closing with an /lifecycle frozen comment.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale
from git-sync.
thockin
commented on August 19, 2024
/lifecycle frozen
/remove-lifecycle stale
from git-sync.
thockin
commented on August 19, 2024
Do you think #110 would cover this need?
from git-sync.
stp-ip
commented on August 19, 2024
It doesn't solve it perfectly, but it gives a good workaround I guess. After merge I can take another look and maybe write up some ideas.
from git-sync.
Related Issues (20)
- Sync on tag addition? HOT 11
- Simplify inner loop
- Consider putting the local repo in a subdir of the --root HOT 3
- Wrong path for check of local git hash HOT 3
- Error msg exposes token in URL HOT 4
- GitLab via ssh key HOT 3
- How to disable commit hash in the target folder? HOT 2
- Allow the submodule functionality for repos copied using vcs tool HOT 1
- Temporarily missing files when using $GITSYNC_LINK HOT 4
- Remediate security vulnerabilities on 4.1.0 HOT 5
- High vulnerability CVE-2023-6246 and CVE-2023-6779 HOT 1
- Issue with PYTHONPATH Resolution in git-sync 4.0.0 HOT 2
- v4 slack webhook HOT 6
- exechook behavior HOT 4
- Remediate 4.2.2 security vulnerabilities HOT 1
- Support GitHub App authentication HOT 7
- TODO: infra to make #878 work HOT 1
- Curious about real example raising race condition when using v3 HOT 1
- exechook working HOT 8
- TODO: shellcheck test_e2e.sh and test_git.sh HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-sync.