Comments (6)
saschagrunert
commented on May 29, 2024
Hey @naveensrinivasan, we already had the discussion about ginkgo in the past and explicitly decided against it. I guess we have now more maintainers onboard, which may share different thoughts.
from security-profiles-operator.
jhrozek
commented on May 29, 2024
On Tue, Jan 19, 2021 at 11:56:11PM -0800, Sascha Grunert wrote:
Hey @naveensrinivasan, we already had the discussion about ginkgo in the past and explicitly decided against it. I guess we have now more maintainers onboard, which may share different thoughts.
My 2c: I would honestly prefer to avoid using Ginkgo or any other framework
that reads more like sentences but less like code.
from security-profiles-operator.
naveensrinivasan
commented on May 29, 2024
Hey @naveensrinivasan, we already had the discussion about ginkgo in the past and explicitly decided against it. I guess we have now more maintainers onboard, which may share different thoughts.
@saschagrunert What are the reasons for not choosing ginkgo? I looked into issues and couldn't find any information. This will help anyone understand the reasons for this explicit decision.
Thanks
from security-profiles-operator.
saschagrunert
commented on May 29, 2024
@saschagrunert What are the reasons for not choosing ginkgo? I looked into issues and couldn't find any information. This will help anyone understand the reasons for this explicit decision.
This was one of the first decisions we took while ramping up the project and that's why we're now using testify. Reducing the complexity of the tests was the major argument these days.
Generally I'm open to re-evaluate the decision and switch if the majority wants to use it.
from security-profiles-operator.
naveensrinivasan
commented on May 29, 2024
@saschagrunert What are the reasons for not choosing ginkgo? I looked into issues and couldn't find any information. This will help anyone understand the reasons for this explicit decision.
This was one of the first decisions we took while ramping up the project and that's why we're now using
testify. Reducing the complexity of the tests was the major argument these days.Generally I'm open to re-evaluate the decision and switch if the majority wants to use it.
@saschagrunert Can you be specifics about what complexity you see in using ginkgo vs testify?
Also on a similar note what are your thoughts on using https://godoc.org/sigs.k8s.io/controller-runtime/pkg/envtest?
IMO Fakeclient are mess kubernetes-sigs/controller-runtime#348 (comment)
The recommended way to test is using envtest without jumping through hoops and not setting up kind cluster for every test. Also with e2e, it is impossible to measure codecoverage.
from security-profiles-operator.
naveensrinivasan
commented on May 29, 2024
My ignorance of not understanding the testify. I can see how testify is comparable with ginkgo but in a more non-bdd driven. Thanks
from security-profiles-operator.
Related Issues (20)
- Create an "Enforce on all Pods" option for Seccomp Profile Bindings
- File Descriptor memory leak on selinux socket comms
- How to log only unique syscalls in audit log file - Security-Profiles-Operator HOT 8
- Vagrant based tests are failing HOT 12
- Autogenerated clientset to access SPO seccompprofile CRs HOT 4
- Support for --http2-disable flag in metrics pod HOT 6
- Running e2e tests on OpenShift hang HOT 1
- AKS spod STATE : UPDATING HOT 12
- Release v0.8.1
- getting owner profile: the node status owner is of an unknown kind HOT 3
- Manage SELinux booleans HOT 10
- tolerations not honoured HOT 4
- AKS eBPF recording HOT 15
- Can not re-install SPO HOT 1
- ignore istio init container while eBPF profiling HOT 8
- AppArmor does not work HOT 15
- Release v0.8.2 HOT 1
- [Question] Disable webhook deployment HOT 4
- Seeing Policy Violations HOT 6
- Security Profiles Operator should support dynamic infrastructures HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from security-profiles-operator.