Comments (6)
nawazkh
commented on August 24, 2024
Hey @ionutleca , thank you for opening up the issue.
What is the network plugin mode being used in your spec? Is it of the type overlay ?
from cluster-api-provider-azure.
ionutleca
commented on August 24, 2024
Hi @nawazkh. Yes, It's overlay.
from cluster-api-provider-azure.
ionutleca
commented on August 24, 2024
There might be an issue in the way I ran these tests, I'm not sure how it can ever end up sending "" to Azure (where that AddressPrefixStringCannotBeNullOrEmpty seems to come from), considering that CAPZ defaults it as soon as we apply the AMCP resource. (irrespective of overlay/noOverlay)
Until I clarify that on my side, can we get a response to the "Is empty string the right value here when referencing existing vnets?" question? I couldn't find any recommendation for this usecase in the docs.
from cluster-api-provider-azure.
ionutleca
commented on August 24, 2024
Sorry for any time wasted, but I couldn't replicate the AddressPrefixStringCannotBeNullOrEmpty in 1.13.* . Might have been just a faulty control plane I was using for tests.
Tested today on CAPZ 1.15.2 (CAPI 1.7.3) with "" CIDR values with and without overlay. Both clusters look healthy.
We just need a go ahead on the "empty string is a good ideea" here.
from cluster-api-provider-azure.
nojnhuh
commented on August 24, 2024
Empty string there seems fine to me. CAPZ should not be making any updates to a pre-created vnet or subnet, so as long as you're not hitting any other errors and the resources look the way you expect in Azure, I think you're good to go. Let us know if you observe otherwise though.
/close
from cluster-api-provider-azure.
k8s-ci-robot
commented on August 24, 2024
@nojnhuh: Closing this issue.
In response to this:
Empty string there seems fine to me. CAPZ should not be making any updates to a pre-created vnet or subnet, so as long as you're not hitting any other errors and the resources look the way you expect in Azure, I think you're good to go. Let us know if you observe otherwise though.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
from cluster-api-provider-azure.
Related Issues (20)
- Add AzureMachinePoolTemplate CRD to support ClusterClass with MachinePools
- BYO VNet Deletion Issues: Route Tables & NSGs
- VMSS VM is in Deleting state, Owner Machine of AzureMachinePoolMachine is not deleted
- Downscaling with cluster-autoscaler (provider clusterapi) scales down wrong MachinePoolMachines
- Add westeurope to e2e test regions
- Hi,
- Management Cluster initiation failed while using User managed Identity for Cluster Provision into our Azure subscription HOT 16
- Deleting a MachinePool can result in stuck AzureMachinePoolMachine due to recreation
- Update ASO dep to 2.8.0 HOT 1
- VMSS reaches limit number of models (10) and can't be scaled anymore HOT 4
- Support AKS uninstall of NetworkPolicyManager as part of upgrading to CNI Overlay HOT 4
- Better UX to indicate the reason of WaitingForInfrastructure when using MachinePool/AzureMachinePool HOT 1
- Migrate Upstream tests to community infrastructure HOT 1
- MachinePool ready state leading to not processing providerIDs in CAPI HOT 1
- Better error message for not setting identity field for UserAssignedIdentity HOT 1
- CAPI v1.8.0-beta.0 has been released and is ready for testing
- Generate API version upgrade test templates with kustomize instead of hard-coding them
- CAPZ doesn't invalidate Azure client cache when only auth mechanism changes
- community infra migration: subscription and regional issues
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cluster-api-provider-azure.