metrics volume is un-sustainable. about kubefed HOT 5 CLOSED

I have it building here with controller 0.11.0 but it forced upgrading to 0.23.2 tehlers320@c22e251

from kubefed.

@irfanurrehman #1492 but it jumps golang versions (i couldnt get it working on 1.16, maybe it was my workstation not sure) and it jumps module versions skipping .22

I also cant get the CLA thing working even though i've signed everything.

with the help from @cebernardi we took out the golang version jump controller 0.10.3 seems to also remove the metrics.

from kubefed.

https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.10.0 <--- this version turns off the rest metric by default.

So it may be as simple as upgrading. https://github.com/kubernetes-sigs/kubefed/blob/master/go.mod#L28

Once upgrading to 0.10.0 to keep the rest_ metrics it looks like we must

	// Deprecated: This metric is deprecated for removal in a future release: using the URL as a
	// dimension results in cardinality explosion for some consumers. It was deprecated upstream
	// in k8s v1.14 and hidden in v1.17 via https://github.com/kubernetes/kubernetes/pull/83836.
	// It is not registered by default. To register:
	//	import (
	//		clientmetrics "k8s.io/client-go/tools/metrics"
	//		clmetrics "sigs.k8s.io/controller-runtime/metrics"
	//	)
	//
	//	func init() {
	//		clmetrics.Registry.MustRegister(clmetrics.RequestLatency)
	//		clientmetrics.Register(clientmetrics.RegisterOpts{
	//			RequestLatency: clmetrics.LatencyAdapter
	//		})
	//	}

from kubefed.

@tehlers320 thanks for pointing out the issue. Would you be able to post a PR with the upgrade for the package. It seems you have already done it privately.

from kubefed.

@irfanurrehman #1492 but it jumps golang versions (i couldnt get it working on 1.16, maybe it was my workstation not sure) and it jumps module versions skipping .22

I also cant get the CLA thing working even though i've signed everything.

from kubefed.