Allow to specify ssh-key via flag about machine-controller HOT 9 CLOSED

Thinking about this some more, I dislike that idea. We should instead remove this whole ssh key deployment functionality everywhere where it is not absolutely required (AWS) and let users pass in their ssh key via the machineSpec if they so chose.

Allowing to pass a ssh key via flag is just an incentive to not put the key in the place it belongs, the machineSpec.

from machine-controller.

Pro:

• We can get rid of ssh key handling code in all providers - except aws

Cons:

• We would need to extend the key handling code in AWS
  • Check if any of the specified ssh keys exists in the account
  • If none of the specified keys exists, we would need to create it -> which one and which name to take?
• Different behavior on the different cloud-providers -> bad user-experience
• We would introduce a hard coupling of the sshPublicKeys property and the cloud-provider

from machine-controller.

No, leave the code for AWS as-is, only remove the handling from the other cloud providers.

from machine-controller.

So we maintain the initial creation of the ssh-key + secret but we simply ignore it for everyone except AWS?
I'm pretty sure this will create the most confusion - as users now see a secret containing a ssh key secret in their cluster although it'll never get used

from machine-controller.

I don't think so, the machine-controller itself is cloud-agnostic, it doesn't have a flag --cloud-provider=<my-cloud-provider> thus it has to do everything that any of the supported clouds may need.

We can just add a note in the Readme why this is needed and also add a comment in the code. I find this much less confusing than creating a ssh key for every cloud provider just because AWS needs it.

from machine-controller.

Need to check if the ssh key is still necessary

from machine-controller.

Digitalocean requires us to specify an ssh key. Otherwise the api will respond with:
The image for this droplet does not use root passwords, please use an SSH key.

AWS, Openstack & Hetzner don't require a SSH key to be specified.

A just had a new idea:
Why not creating a random ssh key during the Digitalocean droplet creation & after successfully creating the droplet, we delete the key?

from machine-controller.

from machine-controller.

closed in favor of #119

from machine-controller.