Giter Club home page Giter Club logo

Comments (6)

MaxNeedsSnacks avatar MaxNeedsSnacks commented on July 17, 2024 1

This has been implemented in AlmostReliable's MoreJS (on 1.18 and 1.19), and because we don't want to reinvent the wheel here, it likely won't be part of KubeJS itself anytime soon, so I'm going to be closing this for now ^^

from kubejs.

Freebi85 avatar Freebi85 commented on July 17, 2024

It would be great for villager trades in general 😄 Afaik KubeJS Fabric has already this feature 😭

Cheers 🍺

from kubejs.

MaxNeedsSnacks avatar MaxNeedsSnacks commented on July 17, 2024

This needs a new feature in architectury, the issue for which can be tracked here: architectury/architectury-api#70

For anyone wanting to help out, feel free to add your thoughts there ^^

from kubejs.

MaxNeedsSnacks avatar MaxNeedsSnacks commented on July 17, 2024

I'd like to wait for architectury/architectury-api#86 before implementing this, since the Architectury API structure may still change until then, but @lythowastaken has actually started work on that, so we may be good to go on this soon

from kubejs.

SeeJayEmm avatar SeeJayEmm commented on July 17, 2024

That architectury issue is closed. Are there any plans to include this in KubeJS?

from kubejs.

Spiker985 avatar Spiker985 commented on July 17, 2024

@MaxNeedsSnacks Architectury issues architectury/architectury-api#70, architectury/architectury-api#84, and architectury/architectury-api#86 pertained to the villager trades - which are all closed.

Do we want to keep this open, and does this need to be marked Forge Specific?

from kubejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.