assets with relative URLs are broken when CSS copied into styleguide about kss-node HOT 9 CLOSED

I found this too:

http://stackoverflow.com/questions/17163208/issue-with-image-referencing-when-generating-a-styleguide-using-kss-node

from kss-node.

Maybe we shouldn't be copying the stylesheet, but instead just referencing the styleguide. Hmmm…

from kss-node.

Sorry i don't follow you @JohnAlbin, this issue was regarding copying a dir?

from kss-node.

Meant to say:

Maybe we shouldn't be copying the stylesheet, but instead just referencing it from the styleguide. Hmmm…

I think this is a deep flaw in the way kss-node works right now. It shouldn't be trying to compile the stylesheets; it causes too many problems like this one.

The best way to handle this is to not have kss-node try to include a stylesheet. Instead use the kss-node --init my-custom-template to create a custom template that you can alter and add in your own stylesheets by hand. That's the way I use kss-node.

This will be "fixed" when #83 is completed.

from kss-node.

interesting, does this mean maintaining x2 stylesheets?

from kss-node.

interesting, does this mean maintaining x2 stylesheets?

Not at all. You would generate your styles the normal way you would for your project. And then just add a link to your generated stylesheet into the styleguide index.html template.

from kss-node.

#83 has been fixed. So the master branch (where kss-node 2.x is being developed) still has the --css option that copies and aggregates CSS files. That still doesn't fix any relative images in the CSS files, though.

So our options are to:

1. fix the relative paths in the CSS (hard!) or
2. just add <link> tags to the template that includes the CSS without copying it.

from kss-node.

just add tags to the template that includes the CSS without copying it.

Created an issue for that in the 2.x branch: #152

I'm leaving this as an open bug in 1.x.

from kss-node.

This is still a bug in 1.x, but since I'm working on 3.x now, I'm going to close this issue. It doesn't appear anyone needs this fixed in 1.x.

from kss-node.