Giter Club home page Giter Club logo

Comments (6)

pambrose avatar pambrose commented on June 6, 2024 1

Ugh. I see the problem. Let me cut a new release.

from kslides.

pambrose avatar pambrose commented on June 6, 2024 1

Yes, you are obviously right! Sorry about that. I added topLeftSvgClass, topLeftSvgStyle, topRightSvgClass, and topRightSvgStyle attributes. If the Class attributes are blank, then they default to "top-left-svg" and "top-right-svg"
I hope those do the trick.
Thanks for the PR!

from kslides.

pambrose avatar pambrose commented on June 6, 2024

Actually, it was not the dumb mistake I thought that it was. The topRightSvg and topLeftSvg were meant to be assigned the actual svg tag details, e.g.,

kslides/kslides-core/src/main/kotlin/com/kslides/config/PresentationConfig.kt

Lines 325 to 330 in d1091ee

topLeftSvg =
"""
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 55 55">
<path fill="currentColor" stroke="none" d="M27.5 11.2a16.3 16.3 0 0 0-5.1 31.7c.8.2 1.1-.3 1.1-.7v-2.8c-4.5 1-5.5-2.2-5.5-2.2-.7-1.9-1.8-2.4-1.8-2.4-1.5-1 .1-1 .1-1 1.6.1 2.5 1.7 2.5 1.7 1.5 2.5 3.8 1.8 4.7 1.4.2-1 .6-1.8 1-2.2-3.5-.4-7.3-1.8-7.3-8 0-1.8.6-3.3 1.6-4.4-.1-.5-.7-2.1.2-4.4 0 0 1.4-.4 4.5 1.7a15.6 15.6 0 0 1 8.1 0c3.1-2 4.5-1.7 4.5-1.7.9 2.3.3 4 .2 4.4 1 1 1.6 2.6 1.6 4.3 0 6.3-3.8 7.7-7.4 8 .6.6 1.1 1.6 1.1 3v4.6c0 .4.3.9 1.1.7a16.3 16.3 0 0 0-5.2-31.7"></path>
</svg>
"""

I will add a topLeftSvgSrc and topRightSvgSrc to accommodate your usage.

from kslides.

pambrose avatar pambrose commented on June 6, 2024

Okay, update your gradle.properties to use kslides_version=0.13.1 and use topRightSvgSrc

from kslides.

xxfast avatar xxfast commented on June 6, 2024

Awesome 🙌 thanks for the quick response. Looks like setting the svg directly with topRightSvgSrc will set the image correctly, but won't apply any styling, and the hense the size will be 0. Is this intended?
Screen Shot 2022-08-31 at 9 34 45 am

Not sure if this is something you can fix with custom styling as the element doesn't have a class of it's own
Screen Shot 2022-08-31 at 9 35 21 am

from kslides.

xxfast avatar xxfast commented on June 6, 2024

Not sure if #18 is the direction you want to handle this issue

from kslides.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.