use Docker images for CI (WIP) about pgfplotsx.jl HOT 21 CLOSED

Cool, hopefully it is faster than the current way of doing stuff.

Although not using the latest nightly might be a bit awkward when we want to upgrade to that... I wonder if it is really necessary to use a Docker image or if we can get fast enough by installing a smaller tex version using apt.

from pgfplotsx.jl.

Yep, if I can make it work. Do you have an idea why it isn't triggered? Maybe only the PRs are sent to Travis, not all branches?

from pgfplotsx.jl.

I changed it so that only PRs are run on Travis because otherwise it always seems to run double CI when you open a PR (one for branch and one for PR). It is fine with me to just open a PR to test stuff out.

from pgfplotsx.jl.

I managed to get it working. The coverage submission error on 0.7 seems to be unrelated.

Build times are 3.5 and 8.5 minutes for 0.6 and nightly (nightly is not in the docker image). I think this is reasonable. I checked coverage info and it seems to be submitted.

Please have a look at it and consider merging. This would allow all other PRs to be tested without timing out.

If you merge, doc generation needs to test for the environment. I made an environment variable for this,

ENV[NAME] ==texlive-julia-docker

should work.

from pgfplotsx.jl.

Hold on, code coverage is submitted, but spuriously. Will fix now.

from pgfplotsx.jl.

Significantly faster!

If you merge, doc generation needs to test for the environment

What does this mean?

from pgfplotsx.jl.

Some people test for being on Travis to deploy documentation. Now I see that you don't, sorry for the misunderstanding.

I expect that we just need to pass -e DOCUMENTER_KEY to docker. My understanding is that this should not show up in the build log so it would not reveal the private key. Please check, and when you say it is OK I can do it. In the worst case, you have to regenerate and reset that key 😄

I checked coverage and it should work now.

from pgfplotsx.jl.

I think we should pass in all of these:

https://github.com/JuliaDocs/Documenter.jl/blob/3e3f0a7b37f0f2a0e7b68ab26cacc3e59648f95d/src/Documenter.jl#L334-L340

from pgfplotsx.jl.

Hmm, looks like Travis isn't building the master branch anymore. I reenabled branch CI's to see if that works.

from pgfplotsx.jl.

Here is the docs deployment error: https://travis-ci.org/KristofferC/PGFPlotsX.jl/jobs/329947612#L575-L597

from pgfplotsx.jl.

I think we need a .ssh directory in the container. This is failing https://github.com/JuliaDocs/Documenter.jl/blob/master/src/Documenter.jl#L466 because (I guess) the folder doesn't exist.

from pgfplotsx.jl.

Working on it, will deploy when the image is generated (2-5 min), then trigger the build.

from pgfplotsx.jl.

What's also disturbing that I return the exit code of cp, fixing that too.

from pgfplotsx.jl.

Now it needs net access 😄 working on it.

from pgfplotsx.jl.

:D

from pgfplotsx.jl.

OK, I realized that if it did not have net access, it could not pull all those packages. So it must be something else, an implicit assumption that is somehow violated. A missing library for something? Would Julia start without missing libraries? I fixed the error passing and restarted the build, so now it should fail.

Don't have any bright ideas on how to debug this ATM, will think about it. If you want something in the Docker image that is missing, let me know.

from pgfplotsx.jl.

I'm unsure what the problem is. Everything seems to work find up until the point that .ssh folder wasn't found? Is there some other problem after that step?

from pgfplotsx.jl.

I am now debugging manually, and git fetch exited because ssh was missing. Will repair that, then see what the next problem is 😄

from pgfplotsx.jl.

Managed to make it work. I may break it again in the next 10 minutes while bisecting which of the n stabs in the dark did the trick, but I will repair after that. The gallery is neat!
https://kristofferc.github.io/PGFPlotsX.jl/latest/examples/gallery.html

from pgfplotsx.jl.

Great job!

from pgfplotsx.jl.

It is fixed now and running clean. In case you are curious: apparently ~/.ssh/config is not enough, I had to create an ~/.ssh/known_hosts, pre-filled with keys for Github, because the first time it is run from Documenter.jl it is run non-interactively, so you cannot confirm that they are OK.

I am closing this issue since the framework is running smoothly, and the error on master is an actual error.

from pgfplotsx.jl.