Comments (5)
FWIW, I just looked at the Q implementation a bit closer and figured out that you get this same behavior without defining when()
in the descriptor at all, since the default rejector is written in exactly the same way. That is, you can comment out the line when: when
in my example and still see the bad behavior.
Also, to be clear, I did these tests with version 0.8.5 as fetched via npm.
from q.
promise.when is not really the primary intended method for resolving a promise, instead you should really use either:
promise.then(onResolved,onRejected);
//or
Q.when(promise, onResolved, onRejected);
However both these exhibit the same behaviour, so that's not the problem. I've submitted a pull request which fixes this, but since makePromise is an advanced feature, I'll have to defer to the author for how it's meant to be used.
from q.
Total sidebar here:
I thought promise.when()
and promise.then()
were synonyms. I'm betraying my prior work experience (on E, quite a while ago) by having picked that over promise.then()
in my example.
Thanks for the recommendation, and thanks for the fix.
from q.
@danfuzz, In Q, promise.when
is an alias that forwards to promise.then. promise.then
in turn is implemented with Q.when. Internally, this uses the "when" message. The words bear the same meaning, but the implementation is wishy-washy about which work should be used for static (Q.when) and dynamic (promise.then, (but also aliased as promise.when)). Q assimilates objects that implement "then" (thenables) into Q promises, but it does not do the same for "whenables" because such things do not exist in the wild.
It’s a bit of a mess, being stuck between the trends in JavaScript and trends in forebears like E.
My inclination is to keep Q.when and promise.then, and remove promise.when so at least you can go by the rule "what makes sense when spoken", but on the other hand, MarkM’s favoring Q(promise).when in the Concurrency Strawman, which I would like to support.
What I mean by the mnemonic, these are the natural choices of words, and the corresponding implied usage in Q.
"When A, B", Q.when(A, B)
"A then B", A.then(B)
from q.
I do really like the idea of sticking to the natural choices of words, I think it might be a nice idea to go with something like Q(promise).then though as the static version, that way they'd both be then.
from q.
Related Issues (20)
- unhandledRejection does not provide promise.stack HOT 1
- Is it possible to use a native Promise object with q ? HOT 1
- async function giving error HOT 1
- Q.allSettled returning unhandled rejection promises HOT 3
- Question : Global Error handling in Promise HOT 2
- Issues with Promise prototype. HOT 1
- Is Q a superset of a native Promise? HOT 4
- How do u like await? HOT 1
- Invalid token q.js?v=1588706333081:854 Invalid token HOT 1
- Google Analytics HOT 7
- Safari drops ticks for backgrounded tasks iOS 14 HOT 13
- Minified release?
- The q4 and after is so hard to understand HOT 1
- In v2, not v1, package.json uses deprecated form of license {} HOT 5
- Add warning and recommend native promises HOT 1
- Why return function ref ? HOT 6
- How can i convert an existing promise to a callback in Node.js ? HOT 1
- Need 'qs' version upadted to latest version to resolve Security Vulnerabilities HOT 2
- rasamaha
- Mark as deprecated on npm? HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from q.