Lines not covered when more tests are run about pcov HOT 17 CLOSED

You seem to have a non-standard directory setup ...

php -dpcov.directory=. -dpcov.exclude="~vendor~" vendor/bin/phpunit tests

That's likely what you are looking for ...

from pcov.

What do you mean by "non-standard"? The src-dev directory? I have removed it and all references to it and still facing the issue. It was all fine a month ago -> https://coveralls.io/builds/23169688 (AFAIR it was PCOV v1.0.2 then).

However, your suggestion fixes it, thanks 👍

from pcov.

from pcov.

Doesn't seems so - there are tests that covers lines that are problematic right now - e.g. https://github.com/kubawerlos/php-cs-fixer-custom-fixers/blob/master/tests/Fixer/InternalClassCasingFixerTest.php#L19 - and as I mentioned, when running only tests from subdirectory tests/Fixer all is covered fine.

from pcov.

You're quite right, something doesn't look right ... (I'm at my keyboard properly now, looking) ...

from pcov.

Can you please try the tip of develop (currently 1.1.0-dev) and patch vendor/phpunit/php-code-coverage/src/Driver/PCOV.php with this stop method:

    /**
     * Stop collection of code coverage information.
     */
    public function stop(): array
    {
        \pcov\stop();

        $waiting  = \pcov\waiting();
        $collect  = [];

        if ($waiting) {
            $collect = \pcov\collect(\pcov\inclusive, $waiting);

            if ($collect) {
                \pcov\clear(\pcov\coverage | \pcov\waiting);
            } else {
                \pcov\clear(\pcov\waiting);
            }
        }

        return $collect;
    }

I believe this produces correct results ?

from pcov.

Yes, it looks so, thanks for a help!

PR: https://github.com/kubawerlos/php-cs-fixer-custom-fixers/pull/98/files
Build: https://travis-ci.org/kubawerlos/php-cs-fixer-custom-fixers/jobs/540456641

from pcov.

I managed to go one better, you no longer need to patch the PHP driver, just update pcov ... 1.0.4-dev (managed to not break compat, so don't need to bump to 1.1) ...

from pcov.

Sorry about all the mess ...

from pcov.

Sorry about all the mess ...

No need to, thanks for the very quick fix 👍

from pcov.

Very welcome.

from pcov.

@krakjoe Can you get folders to coverage from the phpunit.xml?

from pcov.

I think something is still off here, and possibly related to #31 and #38 (my experience lines up with all of these issues). I have a <filter><whitelist> defined in phpunit.xml with some <directory> nodes and an <exclude> node, and those get processed and sent to the pcov driver by phpunit via sebastianbergmann/php-code-coverage. After executing a simple test (using either phpunit or paratest), the resulting test reports show everything as uncovered (including specific lines I know were executed).

If I phpdismod pcov && phpenmod xdebug, my simple test works exactly as expected. Surely php-code-coverage is sending the filter/whitelist to pcov properly, since I can see the source files/methods/lines listed in the coverage report output -- but they're all marked 0%.

from pcov.

To clarify, php-code-coverage doesn't "send" or pass anything from phpunit configuration to pcov. pcov must be configured properly with pcov.directory.

from pcov.

from pcov.

@BHSPitMonkey I agree with you, I expend two days testing pcov with no coverage results due to this issue... I finally found the description here and figured it out to use -dpcov.directory.

from pcov.

Is it possible to run coverage on two folders? I basically have two /app folders -- one is legacy, and one is modern -- and it looks like the only alternative I have is to set directory to . and then exclude everything except those two folders. Is that really what I'd have to do?

EDIT: It looks like this works fine after just setting it to .. From there, it appears that the section of the phpunit.xml config is handling the rest of what I need.

from pcov.