Giter Club home page Giter Club logo

Comments (9)

AustinMroz avatar AustinMroz commented on July 26, 2024 3

I've found the issue and I'll push the fix in the next couple minutes once I've done my sanity checks.

As you guessed initially, when it saves with longer metadata, it uses a different code path. While the logic related to metadata isn't at issue here, the crf information gets added a second time in the command where it shouldn't.

from comfyui-videohelpersuite.

gateway avatar gateway commented on July 26, 2024 2

image

from comfyui-videohelpersuite.

AustinMroz avatar AustinMroz commented on July 26, 2024 2

Not currently, but there was an earlier issue asking about it as well. I'll look into adding it in the future.

from comfyui-videohelpersuite.

AustinMroz avatar AustinMroz commented on July 26, 2024

Metadata wasn't among the changes that was made today, so I have my doubts that it would be related. I'll probably look into lowering the severity of the metadata warning since I've not seen any actual issues caused by it.

The error message provided tells me that the ffmpeg process closed with some error, but doesn't go far enough back to give me any insight on what the issue is. Can you provide earlier logs?

from comfyui-videohelpersuite.

gateway avatar gateway commented on July 26, 2024

image
full stack

from comfyui-videohelpersuite.

AustinMroz avatar AustinMroz commented on July 26, 2024

Thanks, I'm looking into it. Can you check if it breaks with other video formats selected?

from comfyui-videohelpersuite.

gateway avatar gateway commented on July 26, 2024

Its something with my workflow I created because other workflows work.. i have no idea.. i ripped everything out.. I can post the workflow also.. I could be an idiot and doing something wrong. lol :)

workflow

from comfyui-videohelpersuite.

gateway avatar gateway commented on July 26, 2024

Is their a way to opt out of meta data if you dont want to add it, im assuming your adding the workflow..

from comfyui-videohelpersuite.

Kosinkadink avatar Kosinkadink commented on July 26, 2024

A recent PR makes the Broken pipe due to metadata no longer causs everything to break down, and simply retries without the metadata. A save_metadata toggle is also present. Closing the issue, since should have been fixed for a several days now 👍

from comfyui-videohelpersuite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.