Giter Club home page Giter Club logo

Comments (15)

Kosinkadink avatar Kosinkadink commented on June 27, 2024

Make sure to use the Load ControlNet Model (Advanced) node from Advanced-ControlNet instead of the vanilla Load ControlNet Model node. I am considering adding code that will automatically convert non-advance ControlNet objects to advance ones if using my Apply Advanced ControlNet Node, but otherwise I am a bit powerless to easily convert that. Let me know if switching those nodes fixes your issue.

from comfyui-videohelpersuite.

dkamajix avatar dkamajix commented on June 27, 2024

Ah, yes was about to message I figured it.. but thanks. I am suddenly getting another video load error. going tog post here if you dont mind or I can open another issue.
Prompt outputs failed validation
VHS_LoadVideo:

  • Custom validation failed for node: video - Invalid video file: G:\WORKSPACE AI\02_COMFY\ComfyUI_windows_portable\ComfyUI\input\LIVINGROOM_GIRL DANCE_432x768.mp4
  • Custom validation failed for node: upload_to_directory - Invalid video file: G:\WORKSPACE AI\02_COMFY\ComfyUI_windows_portable\ComfyUI\input\LIVINGROOM_GIRL DANCE_432x768.mp4
  • Custom validation failed for node: desired_frame_rate - Invalid video file: G:\WORKSPACE AI\02_COMFY\ComfyUI_windows_portable\ComfyUI\input\LIVINGROOM_GIRL DANCE_432x768.mp4
  • Custom validation failed for node: force_size - Invalid video file: G:\WORKSPACE AI\02_COMFY\ComfyUI_windows_portable\ComfyUI\input\LIVINGROOM_GIRL DANCE_432x768.mp4
  • Custom validation failed for node: frame_load_cap - Invalid video file: G:\WORKSPACE AI\02_COMFY\ComfyUI_windows_portable\ComfyUI\input\LIVINGROOM_GIRL DANCE_432x768.mp4
  • Custom validation failed for node: skip_first_frames - Invalid video file: G:\WORKSPACE AI\02_COMFY\ComfyUI_windows_portable\ComfyUI\input\LIVINGROOM_GIRL DANCE_432x768.mp4
  • Custom validation failed for node: select_every_nth - Invalid video file: G:\WORKSPACE AI\02_COMFY\ComfyUI_windows_portable\ComfyUI\input\LIVINGROOM_GIRL DANCE_432x768.mp4

from comfyui-videohelpersuite.

dkamajix avatar dkamajix commented on June 27, 2024

it was working but suddenly it stopped working..
here is a simple set up still not working
image

from comfyui-videohelpersuite.

Kosinkadink avatar Kosinkadink commented on June 27, 2024

Ah, as part of the fix to the earlier PR, i reverted the input directory to just be "input" again - in your input folder, move the videos out of "VHS_upload" into the outer input folder. The 'VHS_upload' should no longer be part of the path, is this a workflow you just created or one from earlier? And make sure to pull the latest version just in case.

from comfyui-videohelpersuite.

dkamajix avatar dkamajix commented on June 27, 2024

it seems to be inserting that into the path - Input/VHS_upload/
Like if I drag a video from my drive over..
Im not sure what you mean to remove the video from the vhs_upload cus that does not exist in my drive..
"G:\WORKSPACE AI\03_RESOURCES\00_FOOTAGE\04_SD1.5 VIDEOS\POLINA_ORNG\POLINA ORNG DANCE_576x1024.mp4"
that is where the video actually is

image

from comfyui-videohelpersuite.

Kosinkadink avatar Kosinkadink commented on June 27, 2024

Huh, interesting, can you double check that you have the latest version of the code? I thought I had removed that, but maybe not all the way.

from comfyui-videohelpersuite.

dkamajix avatar dkamajix commented on June 27, 2024

sure just uninstall and reinstall right?

from comfyui-videohelpersuite.

Kosinkadink avatar Kosinkadink commented on June 27, 2024

You can do a manual git pull as well, or selecting "update node" in manager, but yep manual reinstall should work too. I would recommend you also do a git pull in th VHS directory after whatever you do regardless so that we get 100% confirmation you are on the latest commit.

from comfyui-videohelpersuite.

dkamajix avatar dkamajix commented on June 27, 2024

I just did (install reinstall - close and restart) and seems like when i drag an mp4 in there it inserts input/VHS_upload/ into the front of the path.
How can I remove those cached list in the node as I load them?
image
if you notice the sumin there are 2 an older and one I just inserted.. the new one has the input/vhs
and should upload to dir be on temp or input

from comfyui-videohelpersuite.

Kosinkadink avatar Kosinkadink commented on June 27, 2024

Oooh, the issue is likely in the js code - if you click the button to upload, it should work, but the dragging functionality needs to be altered. See if clicking the button to upload fixes your problem, I'll work on a fix to the dragging thing in a bit

from comfyui-videohelpersuite.

dkamajix avatar dkamajix commented on June 27, 2024

drag or upload button inserting the pre/ string.
how can I flush the list in there? so there are none?

from comfyui-videohelpersuite.

dkamajix avatar dkamajix commented on June 27, 2024

interestingly - I tried the other load node with path - gave me this diff error.
maybe a clue?
image

from comfyui-videohelpersuite.

dkamajix avatar dkamajix commented on June 27, 2024

regular load video from N-Nodes works but I like yours better mate :)

from comfyui-videohelpersuite.

Kosinkadink avatar Kosinkadink commented on June 27, 2024

Just pushed some changes that should at the very least make the error more informative, let me know if it fixed your issue/changed your error output!

from comfyui-videohelpersuite.

Kosinkadink avatar Kosinkadink commented on June 27, 2024

I just reverted the changes made yesterday, so VHS should be back to stable condition. Let me know if you have any issues now!

from comfyui-videohelpersuite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.