Comments (6)
Do this after merging / discarding PRs to avoid conflicts.
from korge.
I won't have time for this in the shorterm. If someone wants to contribute here, PRs are welcome.
korge-datastructure
is already picked byholloszaboakos
If someone wants to contribute in this split with PRs, feel free to do so. You can put a comment here to avoid other people to doing the same work.
from korge.
We have a problem with circular dependency. We might have to do a bigger refactor than just separating the packages into modules
from korge.
The math and the logger modules use the korlibs-datastructure, therefor we have circular dependency of gradle tasks and this problem is not solvable without gradle changes
from korge.
@holloszaboakos it should be fine:
Just add commonMainApi(project(":korlibs-datastructure"))
in korge-foundation/build.gradle.kts
so the math and logger packages have access to it.
If something from other package is required into datastructure, just copy that functionality into an internal package and provide those functions/classes as internal so they are not exposed.
When
logger
andmath
are split into modules, they can just depend onkorlibs-datastructure
. And if it just uses a couple of functions, then we can do the same: copy them as internal functionality.
from korge.
That doesn't solve circular dependency problem (korlibs-datastructure also needs dependency for foundation). However as we already discussed on discord, we can duplicate code and make that internal.
from korge.
Related Issues (20)
- URL schemes should be case-insensitive, producing only lowercase scheme names for consistency
- if the base URL is empty or not absolute, how should it be resolved? I think we should return the access URL if it's absolute; otherwise, return an empty string or null.
- Unable to get started with "Cannot inline bytecode built with JVM target 11 into bytecode that is being built with JVM target 1.8" error
- `packageJvmWindowsApp` doesn't work with `org.gradle.configuration-cache=true`
- Split korge and korlibs
- Add Support for Subprotocol/subScheme in URL HOT 3
- Change graphics settings at runtime is not working: fps & antialiasing. HOT 1
- readSound.play have issues in JVM windows while readMusic seems to work fine
- KorAU - PlaybackParameters - startTime is not working
- Unexpected results with CharReaderFromSyncStream when chunk size is less than reading count
- Why korlibs-crypto depends on korlibs-time? HOT 1
- LinuxArm64 and other native targets for time and crypto? HOT 4
- Circles and RoundRects not rendering properly (blurry and bad strokes) HOT 1
- Implement `View.positionWithAnchor` when intersection types are available
- Provide a `View.simpleAnimatorSequence`
- Support for watchOS HOT 1
- Fixed Point Integer classes lack some math functions and still use float / doubles in some of their underlying operations.
- Request: Support TCP Low Latency mode for TCP sockets. Also support QUICK ACK for TCP sockets. HOT 3
- Request: Add Support for UDP Connections in KorGE "common" code. HOT 5
- Issue with importing firebase gitlive 1.11.1 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from korge.