Giter Club home page Giter Club logo

Comments (6)

soywiz avatar soywiz commented on June 12, 2024

Do this after merging / discarding PRs to avoid conflicts.

from korge.

soywiz avatar soywiz commented on June 12, 2024

I won't have time for this in the shorterm. If someone wants to contribute here, PRs are welcome.

  • korge-datastructure is already picked by holloszaboakos

If someone wants to contribute in this split with PRs, feel free to do so. You can put a comment here to avoid other people to doing the same work.

from korge.

holloszaboakos avatar holloszaboakos commented on June 12, 2024

We have a problem with circular dependency. We might have to do a bigger refactor than just separating the packages into modules

from korge.

holloszaboakos avatar holloszaboakos commented on June 12, 2024

The math and the logger modules use the korlibs-datastructure, therefor we have circular dependency of gradle tasks and this problem is not solvable without gradle changes

from korge.

soywiz avatar soywiz commented on June 12, 2024

@holloszaboakos it should be fine:

Just add commonMainApi(project(":korlibs-datastructure")) in korge-foundation/build.gradle.kts so the math and logger packages have access to it.

If something from other package is required into datastructure, just copy that functionality into an internal package and provide those functions/classes as internal so they are not exposed.

When logger and math are split into modules, they can just depend on korlibs-datastructure. And if it just uses a couple of functions, then we can do the same: copy them as internal functionality.

from korge.

holloszaboakos avatar holloszaboakos commented on June 12, 2024

That doesn't solve circular dependency problem (korlibs-datastructure also needs dependency for foundation). However as we already discussed on discord, we can duplicate code and make that internal.

from korge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.