Giter Club home page Giter Club logo

Comments (13)

aalmiray avatar aalmiray commented on August 17, 2024

@MarceloRuiz this is pretty cool, I like it! Would you consider contributing the code to the Ikonli project? If so you'd retain authorship 😄

I'd also suggest to add an area at the top that displays the icon constant when any of the buttons is clicked. That way you don't have to wait for the tooltip to appear. Also, users may copy the value if the area is a non-editable textfield/textarea.

from ikonli.

MarceloRuiz avatar MarceloRuiz commented on August 17, 2024

@aalmiray
I would be happy to contribute the code to the ikonli project. How should I do that exactly?
Regarding the area for users to copy the icon constant, I could add it, but wouldn't that be redundant? The way I implemented it is that when the users clicks on any of the icons, the icon constant get copied to the user's system clipboard, so he/she can just paste whenever the value is needed. But I would be happy to add the area if you think it will help...

from ikonli.

aalmiray avatar aalmiray commented on August 17, 2024

Great. We can start by adding another subproject to the build (like sampler-javafx). Once it's done, send me a PR with the changes 😄

from ikonli.

MarceloRuiz avatar MarceloRuiz commented on August 17, 2024

Hi Andres, sorry it took me so long to get back to you. I was traveling and life is quite complicated for me until the end of the year (hopefully easier after that!).
I created a new version of the program I would like you to review. I called it "Ikonli Icon Finder" because it has now a search capability and multiple icon families can be displayed simultaneously. Tell me if you think it is ready for prime time.
Also, I have never worked with github. Should I be adding a subproject? Can you point me into the right direction?
Best,
Marcelo.

PS: As before, I just added the .zip extension to be able to upload it.
Ikonli-Icon-Finder.jar.zip

from ikonli.

aalmiray avatar aalmiray commented on August 17, 2024

@MarceloRuiz could you give me access to the sources?

from ikonli.

eitsch avatar eitsch commented on August 17, 2024

@MarceloRuiz sorry to interrupt, i just tried to get your jar to run and fell into two traps. i now know the right way, but will not really bother doing that. Please bear in mind that i am just an unimportant consumer who drove by your excellent idea.

  • first trap: Running it in Java 8 does not work as it was compiled with java >= 9
  • second trap: running it in Java 11 does not work as "someone" 😈 decided that javafx should not be part of jdk anymore

i understand that i probably now need to download a java 9 to get your jar running. 😿 //edit: or pimp my classpath with some jafafx libraries

integrating your fine idea via PR (or attaching your zipped sources) would really be a nice addition to this already fine project 👍

from ikonli.

aalmiray avatar aalmiray commented on August 17, 2024

Well, the README does say that Java 11 is required. If you're following the news then you should know that JavaFX 11 is now provided as a separate download. This being said, the guide could make it more explicit and perhaps provide an example on how to set it up. Meanwhile https://openjfx.io/openjfx-docs/#gradle could help as a starting point.

from ikonli.

eitsch avatar eitsch commented on August 17, 2024

Hi Andres @aalmiray, my comment (also the "traps") was relating to the jar/zip that @MarceloRuiz linked. I was hoping i could "just run that jar without needing to checkout/setup anything else"

I understand that getting JavaFX set up is needed and that your README mentions the baseline of Java 11. I also now (while writing) understand your point of view better, i guess: If i want to build/use ikonli, i need to get all this set up anyways.

Thank you for supplying the helpful link to JavaFX / gradle info! 👍

from ikonli.

ThomasDaheim avatar ThomasDaheim commented on August 17, 2024

Unfortunately, this hasn't gone anywhere? Would really be nice to have some kind of "browsing" component to allow users to select icons for themselves...

from ikonli.

aalmiray avatar aalmiray commented on August 17, 2024

I'm working on it as we speak, an application named ikonli-browser which will be available right after 12.0.0 comes out (this weekend).

https://twitter.com/aalmiray/status/1325164720635207681

from ikonli.

ThomasDaheim avatar ThomasDaheim commented on August 17, 2024

Perfect! Exactly what I need at exactly the right moment! I'm working on adding tags to my https://github.com/ThomasDaheim/ownNoteEditor and wanted to be able to choose an icon per tag.

from ikonli.

ThomasDaheim avatar ThomasDaheim commented on August 17, 2024

And good to know that someone is still working to improve things in JavaFX :-)

from ikonli.

aalmiray avatar aalmiray commented on August 17, 2024

An icon browser is already in place. Binaries currently posted to the early-access release https://github.com/kordamp/ikonli/releases/tag/12.3.0.EarlyAccess

from ikonli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.