Make a footer part of the site as a react element about sample-app-react HOT 9 CLOSED

Hi,

that's great to hear @sandiri-s. I think this task is perfect as a first contribution.
Please go through the Code of conduct and Contributing guidelines to get familiar with our contribution process.

If you have any question, or you need to specify the issue requirement, feel free to ask here.

Looking forward for the pull request
Ondřej

from sample-app-react.

Hi, I would like to contribute to this issue. I have worked on the few samples react applications in the past and this will be my first open source contribution.

Thanks.

from sample-app-react.

Hi @sandiri-s , if you accept the collaborator invite I've just sent you, we'll be able to assign the issue directly to you.

from sample-app-react.

I'd like to contribute to this issue and fix it right away. Please let me know.

from sample-app-react.

folks, whoever submits the PR first, wins :D so go for it!

from sample-app-react.

Is this still open?

from sample-app-react.

there's a PR open for this - #67

from sample-app-react.

@jmb521 it is nearly the month, since the last action was made in the pull request.

So if you are interested create your own pull request, let!s do it.

Take a look to the pull request comments:
#67

The work consist from:

• move html from index.html to the component (do not forget to change class attributes to className)
• change display type of the footer element in css (desribed in pullrequest comment)
• (optionally) set up the translation for the element as is in other components

If you have any question, feel free to ask :-)

from sample-app-react.

Implemented in #70

from sample-app-react.