Migrate the application to ASP.NET Core MVC about sample-app-net HOT 10 CLOSED

@charithsoori let me please check with my colleagues what the exact expectations are. i'll get back to you soon.

from sample-app-net.

Yeah, 2.2 is better, of course.

from sample-app-net.

@petrsvihlik This task is interesting. Are you expecting a single pull request? And also do you have a separate GitHub branch for this?

from sample-app-net.

Good news @charithsoori ! You can start working on it :)

Regarding the workflow:

• I gave you write permissions to the repository which means that you can create own branch next to master and start pushing the code there.
• We won't merge it to master until it's done and thoroughly tested. The code reviews and testing will be done by @JanLenoch who will also provide you with guidance and/or assistance if needed. (Just mention him in a comment and he'll get back to you asap.)
• Before we merge the changes, we'll backup the original code in a separate branch. (Will be done by @JanLenoch )
• I've also committed the appveyor.yml file to the repository in case you need to adjust the build procedure (eg. remove vs 2015 builds as vs 2015 doesn't support asp.net core 2.0)

Some technical details regarding referenced NuGet packages:

• microsoft.* and system.* should be fine (they should have their .net standard alternative)
• anglesharp supports netstandard = ok
• kenticocloud.* supports netstandard = ok
• jquery&bootstrap are not dependent on clr = ok
• antlr is used by webgrease which is used by Microsoft.AspNet.Web.Optimization (for js/css bundling)...we can replace it with an analogical asp.net core package...see the docs

Target ASP.NET Core version should be: 2.0

I expect the biggest changes to be in the configuration.
Also there may be some places where we can make use of the view components and some other new ASP.NET Core functionality. Feel free to refactor the code to use the latest standards.
We should also take advantage of Dependency Injection to inject services like DeliveryClient into controllers.

from sample-app-net.

Indeed a great news @petrsvihlik .

• The git-flow you suggested is very clean and ill send pull requests to migration branch from my fork.
• The initial technical spec is very clear.
  Ill work start work on this.

from sample-app-net.

Hi @charithsoori ,

How is it going with the conversion? I was wondering if there's anything I could help you with. If so, just let me know.

Jan

from sample-app-net.

Hi @JanLenoch
Bit away for a vacation these days and haven’t started the task yet . I’ll update you soon when I start the task.

from sample-app-net.

Cool, no pressure. If there's anything I can help with, just let me know.

from sample-app-net.

Is .net core 2.1 still the target? 2.2 has been released.

from sample-app-net.

moved to: https://github.com/Kentico/delivery-sdk-net/issues/158

from sample-app-net.