The host attribute should not be required about kubernetes-ingress-controller HOT 14 CLOSED

Hello @jaygorrell,

Thanks for opening this issue, I can confirm this bug.
The issues arises because of the way ingress resources are translated into Kong Routes and Services.
We will try to fix this up soon.
PRs from community are welcome as well!

from kubernetes-ingress-controller.

Hello @fresh618 @alexchansun, #190 fixes this issue.
It will be merged in soon and will be available in our next release coming out later this week!

from kubernetes-ingress-controller.

@theissn This is not yet available in any release. The feature will be included in the upcoming 0.2.1 and 0.1.2 releases happening later this month.

from kubernetes-ingress-controller.

@hbagdi I'm interested in trying to fix this. Can you give a hint of what to look at?

from kubernetes-ingress-controller.

Heya!

Just tried the above example running the latest version of kong and nothing registers.

kind: Ingress
metadata:
  name: foo
spec:
  rules:
  - http:
      paths:
      - path: /foo
        backend:
          serviceName: foo
          servicePort: 80

Any ideas?

from kubernetes-ingress-controller.

I noticed that you released 0.1.2/0.2.1 this weekend (October 26, 2018). I'm using kong:0.13.1-centos, so I updated my kubernetes-ingress-controller from 0.1.0 to 0.1.2. However, much like @theissn, my Ingress controller didn't register with Kong unless I restored the host rule.

FWIW: I originally deployed Kong using https://raw.githubusercontent.com/Kong/kubernetes-ingress-controller/96b2f0b73bd19df9264ee212dae53b935c10e501/deploy/single/all-in-one-postgres.yaml

from kubernetes-ingress-controller.

@slkinnison, I used Kong 0.13.1-centos with Kong Ingress Controller 0.1.2, and it works fine.
Could you share some reproducible steps?

from kubernetes-ingress-controller.

Thanks for getting back to me so fast!

The diff of my update to all-in-one-postgres.yaml:

386c386
<         image: kong-docker-kubernetes-ingress-controller.bintray.io/kong-ingress-controller:0.1.0
---
>         image: kong-docker-kubernetes-ingress-controller.bintray.io/kong-ingress-controller:0.1.2
416c416
<   type: NodePort
---
>   type: LoadBalancer

The new echoserver's Ingress specification:

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: foo-bar
  namespace: bnb
spec:
  rules:
  - http:
      paths:
      - path: /bnb2
        backend:
          serviceName: http-svc
          servicePort: 80

from kubernetes-ingress-controller.

@slkinnison,

Just to make sure, you did bump the version of your Ingress controller to 0.1.2, right? Cause that's not what I see in the diff.

from kubernetes-ingress-controller.

In the diff above the change on line 386 was to change the version from 0.1.0 to 0.1.2. Did I miss a change somewhere else in all-in-one-postgres.yaml?

from kubernetes-ingress-controller.

@slkinnison Apologies, I didn't read the diff output correctly.

I can replicate it.
It seems like you need one host based rule along with other empty host for this to work. There seems to be an error in the Ingress controller in how it is parsing the Ingress objects.

The following works:

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: ingress-test-1
  annotations:
spec:
  rules:
  - http:
      paths:
      - path: /mypath-2
        backend:
          serviceName: http-svc
          servicePort: 80
    host: foo.com
  - http:
      paths:
      - path: /mypath-2
        backend:
          serviceName: http-svc
          servicePort: 80

But, the following doesn't:

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: ingress-test-2
  annotations:
spec:
  rules:
  - http:
      paths:
      - path: /mypath-2
        backend:
          serviceName: http-svc
          servicePort: 80

from kubernetes-ingress-controller.

Thanks for digging into this. I'll adjust my settings accordingly.

from kubernetes-ingress-controller.

@hbagdi Do you have any plan for making the following Ingress works?

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: ingress-test-2
  annotations:
spec:
  rules:
  - http:
      paths:
      - path: /mypath-2
        backend:
          serviceName: http-svc
          servicePort: 80

from kubernetes-ingress-controller.

@hbagdi Nginx-ingress works very well, do you have plans to fix this bug?
Thanks

from kubernetes-ingress-controller.