Giter Club home page Giter Club logo

Comments (5)

jeromeguillaume avatar jeromeguillaume commented on September 26, 2024

There is an impact on Konnect - API Product too.
Right now if you define, for instance, 3 HTTPRoutes concerning the same Kubernetes Service, you have 3 Gateway Services and consequently 3 API Products. So finally we have 3 entries in the Developer Catalog whereas it's the same API (i.e. same Kubernetes service)

from kubernetes-ingress-controller.

randmonkey avatar randmonkey commented on September 26, 2024

A question about naming of translated services: how should we name the translated Kong services, as they can come from different HTTPRoutes:

  • Use the same pattern httproute.<namespace>.<name>.<rule index> of the "first" HTTPRoute rule in some consistent order (like alphabetical order of NS and name)
  • Use attributes of backends like the pattern svc.<ns>.<name> as Ingress do
  • Use a hash of the attributes of backends
    I would choose (1) because there are too many attributes on backends of HTTPRoutes. (1) could give a more controllable pattern of names.

from kubernetes-ingress-controller.

piotrwielgolaski-tomtom avatar piotrwielgolaski-tomtom commented on September 26, 2024

I would love ingress format, but it could be problematic if different filtered are used.

Version relying on index of first route sound risky, as adding new route could change service name

maybe ingress format followed by has of parameters like filters.

from kubernetes-ingress-controller.

piotrwielgolaski-tomtom avatar piotrwielgolaski-tomtom commented on September 26, 2024

Also it would be very useful to know k8s service and namespace in access log

from kubernetes-ingress-controller.

randmonkey avatar randmonkey commented on September 26, 2024

@mheap I want to discuss what are included in the "target ref" to group Kong services:

  • Should we include filters? In the current supported filters, we translate them to plugins attached to Kong routes. So filters does not affect attributes of services. And also we do not support per backend filters. If we do not translate them (also no potential supporting filters) to fields or plugins of Kong services, I think it is OK to ignore filters in grouping Kong services.
  • Should we consider timeouts? The timeouts of rules affects *_timeout of Kong service, but the existing logic of combining services already grouped rules with same backends but different timeouts.

Also, should we put this feature behind a feature gate and disable it by default? I think yes (like what we have done for CombinedRoutes and CombinedServices) because it is a significant and user facing change, and there will be pontetial changes happen to the feature itself.

from kubernetes-ingress-controller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.