Giter Club home page Giter Club logo

Comments (6)

gdhagger avatar gdhagger commented on June 6, 2024 1

Spent some time yesterday trying to use the annotation to point to a KongIngress and found I was getting log messages that the plugin could not be found.

Looking at the code, it appears that getKongPlugin is being used to retrieve all types of CRD defined in annotations, where getKongIngress should be used for these.

from kubernetes-ingress-controller.

jaygorrell avatar jaygorrell commented on June 6, 2024

Came to report the same thing. I couldn't get this to work at all when using the annotation. Like @devdavidkarlsson mentioned, the name matching works better but I was still unable to get changes to be picked up until I delete/recreate the Ingress resource after the KongIngress is updated.

from kubernetes-ingress-controller.

hbagdi avatar hbagdi commented on June 6, 2024

Hi all,

Thank you for the report.
I've been going through the issues and addressing them one by one.
I'm going tot take this up next and provide a fix soon. Stay tuned!

from kubernetes-ingress-controller.

hbagdi avatar hbagdi commented on June 6, 2024

I think the annotation that is document is incorrect.

As per docs, the annotation should be ingress.plugin.konghq.com while really the required annotation is configuration.konghq.com.

Can you guys any of you try that? Thanks!

from kubernetes-ingress-controller.

jaygorrell avatar jaygorrell commented on June 6, 2024

Yep, that was it! It still doesn't pick up changes unless I delete/recreate the Ingress, but it's at least reading the values from a shared resource with that annotation change. Maybe another ticket would make sense for live updates?

from kubernetes-ingress-controller.

hbagdi avatar hbagdi commented on June 6, 2024

Yep, that was it!

Nice! I will make a PR to update the documentaion.

It still doesn't pick up changes unless I delete/recreate the Ingress, but it's at least reading the values from a shared resource with that annotation change. Maybe another ticket would make sense for live updates?

This was left as a future TODO in the past in the code base. I guess it warrants another issue so please open one up.

Thank you for trying the above annotation! Stay tuned for fixes.

from kubernetes-ingress-controller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.